-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle trailing slash on endpoint for otlphttp #8083
Handle trailing slash on endpoint for otlphttp #8083
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8083 +/- ##
=======================================
Coverage 90.70% 90.70%
=======================================
Files 300 300
Lines 15164 15167 +3
=======================================
+ Hits 13754 13757 +3
Misses 1128 1128
Partials 282 282
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cartermp please add a changelog entry by running make chlog-new
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add some new tests to factory_test.go to test this behavior.
did I do this or is this just kinda a thing sometimes? |
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
This makes it so we don't put a double slash on the endpoint for otlphttp when it exists.
The spec says that this kind of stuff should be handled w.r.t. the OTEL_EXPORTER_OTLP_ENDPOINT env var and says nothing about programmatic handling of this config. But I still think it's a worthwhile change on a common-ish[1] ergonomic issue.
[1] while the collector isn't the only source of this, at honeycomb we emitted an error related to a misconfigured otlphttp endpoint ~2.5 million times over the past month
fixes #8084