Handle trailing slash on endpoint for otlphttp #8084
Comments
codeboten
pushed a commit
that referenced
this issue
Jul 13, 2023
This makes it so we don't put a double slash on the endpoint for otlphttp when it exists. The spec says that this kind of stuff should be handled w.r.t. the OTEL_EXPORTER_OTLP_ENDPOINT env var and says nothing about programmatic handling of this config. But I still think it's a worthwhile change on a common-ish[1] ergonomic issue. [1] while the collector isn't the only source of this, at honeycomb we emitted an error related to a misconfigured otlphttp endpoint ~2.5 million times over the past month fixes #8084 --------- Co-authored-by: Alex Boten <aboten@lightstep.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current otlphttpexporter doesn't handle when there's already a trailing slash in the configured endpoint.
The spec says that this kind of stuff should be handled w.r.t. the OTEL_EXPORTER_OTLP_ENDPOINT env var and says nothing about programmatic handling of this config. But I still think it's a worthwhile change on a common-ish[1] ergonomic issue.
[1] while the collector isn't the only source of this, at honeycomb we emitted an error related to a misconfigured otlphttp endpoint ~2.5 million times over the past month
The text was updated successfully, but these errors were encountered: