Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle trailing slash on endpoint for otlphttp #8083

Merged
merged 8 commits into from
Jul 13, 2023
Merged

Handle trailing slash on endpoint for otlphttp #8083

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ab2fef1
Handle trailing slash on endpoint for otlphttp
cartermp Jul 12, 2023
cf3a208
use strings
cartermp Jul 12, 2023
3d56e64
appease the lint robot
cartermp Jul 12, 2023
8c25c8b
add changelog entry
cartermp Jul 12, 2023
085ee75
Add test
cartermp Jul 12, 2023
16c9664
appease the robots
cartermp Jul 12, 2023
20cc277
Apply suggestions from code review
codeboten Jul 12, 2023
11ca87c
Update .chloggen/otlphttpexporter-trailing-slash.yaml
cartermp Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions exporter/otlphttpexporter/factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"context"
"fmt"
"net/url"
"strings"
"time"

"go.opentelemetry.io/collector/component"
Expand Down Expand Up @@ -61,6 +62,9 @@ func composeSignalURL(oCfg *Config, signalOverrideURL string, signalName string)
case oCfg.Endpoint == "":
return "", fmt.Errorf("either endpoint or %s_endpoint must be specified", signalName)
default:
if strings.HasSuffix(oCfg.Endpoint, "/") {
return oCfg.Endpoint + "v1/" + signalName, nil
}
return oCfg.Endpoint + "/v1/" + signalName, nil
}
}
Expand Down