Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add torchvision roi_align with aligned=True #581

Merged
merged 4 commits into from
Sep 25, 2020

Conversation

grimoire
Copy link
Member

Hi
torchvision.ops.roi_align support aligned flag now. pytorch/vision#1908.
This PR enable aligned flag when use_torchvision=True in mmcv.ops.RoIAlign

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #581 into master will increase coverage by 0.11%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
+ Coverage   64.76%   64.87%   +0.11%     
==========================================
  Files         133      134       +1     
  Lines        7597     7619      +22     
  Branches     1336     1344       +8     
==========================================
+ Hits         4920     4943      +23     
+ Misses       2432     2426       -6     
- Partials      245      250       +5     
Flag Coverage Δ
#unittests 64.87% <54.54%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/roi_align.py 64.06% <0.00%> (-4.79%) ⬇️
mmcv/runner/iter_based_runner.py 25.36% <36.36%> (+7.93%) ⬆️
mmcv/runner/epoch_based_runner.py 79.04% <62.50%> (+0.25%) ⬆️
mmcv/runner/__init__.py 100.00% <100.00%> (ø)
mmcv/runner/base_runner.py 70.67% <100.00%> (+0.28%) ⬆️
mmcv/runner/builder.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b52e9b...a52201a. Read the comment docs.

@hellock
Copy link
Member

hellock commented Sep 25, 2020

Thanks for the notification!

@hellock hellock merged commit 467b488 into open-mmlab:master Sep 25, 2020
wxzs5 pushed a commit to wxzs5/mmcv that referenced this pull request Nov 20, 2020
* add torchvision roi_align with aligned=True

* fix for lint test

* fix for lint test2

* format use yapf
mattdawkins added a commit to VIAME/mmcv that referenced this pull request Dec 3, 2020
* tag 'v1.1.5': (81 commits)
  bump version to 1.1.5 (open-mmlab#603)
  Fix wrappers version comparison (open-mmlab#602)
  revert dcn (open-mmlab#597)
  lint markdown files (open-mmlab#592)
  bump version to 1.1.4 (open-mmlab#591)
  fix lint open-mmlab#580 (open-mmlab#590)
  Fixed fp16_optimizer state bug (open-mmlab#580)
  register deconv in CONV_LAYERS (open-mmlab#582)
  [enhance]: show grad norm in fp16 optimizer hook (open-mmlab#584)
  [Enhance] Switch to https://download.openmmlab.com (open-mmlab#583)
  Support to specify LR of DCN's conv_offset (open-mmlab#344)
  add torchvision roi_align with aligned=True (open-mmlab#581)
  Add runner builder (open-mmlab#570)
  [fix]: fix wrapper comparison of pytorch version (open-mmlab#572)
  Add missing by_epoch arg (open-mmlab#576)
  merge the calling of train/val_step and batch_processor into run_iter (open-mmlab#553)
  bump version to 1.1.3 (open-mmlab#569)
  fix deprecated wrappers exiting bug (open-mmlab#567)
  add switch for onnx exporter (open-mmlab#564)
  fix dcon forward and backward bug (open-mmlab#565)
  ...
@grimoire grimoire deleted the fix_roi_aligned branch January 11, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants