Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to specify LR of DCN's conv_offset #344

Merged
merged 19 commits into from
Sep 25, 2020

Conversation

ZwwWayne
Copy link
Collaborator

This PR add an option dcn_offset_lr_mult in params_cfg. The modification enables to set the learning rate of DCN's conv offset layer to stabilize training.

@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #344 into master will increase coverage by 0.18%.
The diff coverage is 66.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   64.76%   64.95%   +0.18%     
==========================================
  Files         133      134       +1     
  Lines        7597     7632      +35     
  Branches     1336     1346      +10     
==========================================
+ Hits         4920     4957      +37     
+ Misses       2432     2425       -7     
- Partials      245      250       +5     
Flag Coverage Δ
#unittests 64.95% <66.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/roi_align.py 64.06% <0.00%> (-4.79%) ⬇️
mmcv/runner/iter_based_runner.py 25.36% <36.36%> (+7.93%) ⬆️
mmcv/runner/epoch_based_runner.py 79.04% <62.50%> (+0.25%) ⬆️
mmcv/runner/optimizer/default_constructor.py 97.89% <83.33%> (-2.11%) ⬇️
mmcv/ops/deform_conv.py 65.83% <100.00%> (+0.28%) ⬆️
mmcv/runner/__init__.py 100.00% <100.00%> (ø)
mmcv/runner/base_runner.py 70.67% <100.00%> (+0.28%) ⬆️
mmcv/runner/builder.py 100.00% <100.00%> (ø)
mmcv/utils/ext_loader.py 54.16% <100.00%> (+9.16%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467b488...f1704e8. Read the comment docs.

mmcv/runner/optimizer/default_constructor.py Outdated Show resolved Hide resolved
mmcv/runner/optimizer/default_constructor.py Outdated Show resolved Hide resolved
@hellock
Copy link
Member

hellock commented Sep 11, 2020

Copy link
Member

@hellock hellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding offset_lr_mult to the init method may be confusing when users are not using the default optimizer constructor.

@hellock hellock merged commit ed2887b into open-mmlab:master Sep 25, 2020
wxzs5 pushed a commit to wxzs5/mmcv that referenced this pull request Nov 20, 2020
* Support to specify LR of DCN's conv_offset

* Resolve comments & add unit test

* Resolve formats

* Fix CI for DCN

* Mock DCN when cpu only

* Use mock for cpu testing

* Fix docstring and support ModulatedDCN

* set offset_lr_mult as dcn's arguments, link CU-49u01p

* fix lr bug

* fall back to set LR in constructor

* resolve comments
mattdawkins added a commit to VIAME/mmcv that referenced this pull request Dec 3, 2020
* tag 'v1.1.5': (81 commits)
  bump version to 1.1.5 (open-mmlab#603)
  Fix wrappers version comparison (open-mmlab#602)
  revert dcn (open-mmlab#597)
  lint markdown files (open-mmlab#592)
  bump version to 1.1.4 (open-mmlab#591)
  fix lint open-mmlab#580 (open-mmlab#590)
  Fixed fp16_optimizer state bug (open-mmlab#580)
  register deconv in CONV_LAYERS (open-mmlab#582)
  [enhance]: show grad norm in fp16 optimizer hook (open-mmlab#584)
  [Enhance] Switch to https://download.openmmlab.com (open-mmlab#583)
  Support to specify LR of DCN's conv_offset (open-mmlab#344)
  add torchvision roi_align with aligned=True (open-mmlab#581)
  Add runner builder (open-mmlab#570)
  [fix]: fix wrapper comparison of pytorch version (open-mmlab#572)
  Add missing by_epoch arg (open-mmlab#576)
  merge the calling of train/val_step and batch_processor into run_iter (open-mmlab#553)
  bump version to 1.1.3 (open-mmlab#569)
  fix deprecated wrappers exiting bug (open-mmlab#567)
  add switch for onnx exporter (open-mmlab#564)
  fix dcon forward and backward bug (open-mmlab#565)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants