Add runner builder #570
Merged
Add runner builder #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
+ Coverage 64.69% 64.91% +0.21%
==========================================
Files 133 134 +1
Lines 7600 7616 +16
Branches 1338 1342 +4
==========================================
+ Hits 4917 4944 +27
+ Misses 2435 2422 -13
- Partials 248 250 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ZwwWayne
approved these changes
Sep 21, 2020
hellock
reviewed
Sep 24, 2020
hellock
approved these changes
Sep 25, 2020
wxzs5
pushed a commit
to wxzs5/mmcv
that referenced
this pull request
Nov 20, 2020
* Add build_runner * Parametrize test_runner * Add imports to runner __init__ * Refactor max_iters and max_epochs from run to init * Add assertion error messages * Add test_builder * Make change retro-compatible * Raise ValueError if max_epochs and max_iters
mattdawkins
added a commit
to VIAME/mmcv
that referenced
this pull request
Dec 3, 2020
* tag 'v1.1.5': (81 commits) bump version to 1.1.5 (open-mmlab#603) Fix wrappers version comparison (open-mmlab#602) revert dcn (open-mmlab#597) lint markdown files (open-mmlab#592) bump version to 1.1.4 (open-mmlab#591) fix lint open-mmlab#580 (open-mmlab#590) Fixed fp16_optimizer state bug (open-mmlab#580) register deconv in CONV_LAYERS (open-mmlab#582) [enhance]: show grad norm in fp16 optimizer hook (open-mmlab#584) [Enhance] Switch to https://download.openmmlab.com (open-mmlab#583) Support to specify LR of DCN's conv_offset (open-mmlab#344) add torchvision roi_align with aligned=True (open-mmlab#581) Add runner builder (open-mmlab#570) [fix]: fix wrapper comparison of pytorch version (open-mmlab#572) Add missing by_epoch arg (open-mmlab#576) merge the calling of train/val_step and batch_processor into run_iter (open-mmlab#553) bump version to 1.1.3 (open-mmlab#569) fix deprecated wrappers exiting bug (open-mmlab#567) add switch for onnx exporter (open-mmlab#564) fix dcon forward and backward bug (open-mmlab#565) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This P.R. adds a new method
build_runnerand a new Registry object:RUNNERSfor managing runner types.This allows to specify runner type (and corresponding parameters) via configuration files.
The
max_itersandmax_epochsarguments have been moved fromrunto__init__(this change is backwards compatible with deprecation warning).I don't know if there was a use case that needed to have them in
runbut in all downstream repos (mmdet, mmseg, etc) those args were parsed from config so i think it makes sense to set them during instantiation.Discussed in open-mmlab/mmsegmentation#118