Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an initial first set of a repeating group when it is required #2345

Open
hlmr-erik opened this issue Nov 14, 2022 · 5 comments
Open

Show an initial first set of a repeating group when it is required #2345

hlmr-erik opened this issue Nov 14, 2022 · 5 comments

Comments

@hlmr-erik
Copy link

hlmr-erik commented Nov 14, 2022

Thema / Theme

Frontend

Omschrijving / Description

When having a repeating group as required, at least one instance needs to be filled in. As it is now, a user still has to invoke the fields by clicking the "+" button. This seems unnecessary to me. Showing an initial set of fields in this case would fix this story #2344 as well; since the required-asterisk wouldn't be needed at all at the repeating-group level; the asterisks at the fields (now showing immediately on tab load) would suffice.

Added value / Toegevoegde waarde

Make the initial appearance of fields match the intention set in the form.

Aanvullende opmerkingen / Additional context

How a first show looks now:
image

How I see it as more desirable:
image

@hlmr-erik hlmr-erik added the triage Issue needs to be validated. Remove this label if the issue considered valid. label Nov 14, 2022
@hlmr-erik hlmr-erik changed the title Show an initial first set of a repeating group Show an initial first set of a repeating group when it is required Nov 14, 2022
@hlmr-erik
Copy link
Author

hlmr-erik commented Nov 15, 2022

Reading the documentation, it seems like a similar feature was planned/implemented before? https://open-forms.readthedocs.io/en/2.0.0_a/manual/forms/examples/repeating_groups.html
image

However, I don't see this mentioned option in the properties window of 2.0.0:
image

@sergei-maertens
Copy link
Member

sergei-maertens commented Nov 16, 2022

Yes, but we ran into formio bugs and decided to scrap that option :(

See #2081 for context, adding blocked label as this is blocked by formio/formio.js#4620

@sergei-maertens sergei-maertens added blocked formio Limitation in Formio.js and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Nov 16, 2022
@sergei-maertens
Copy link
Member

@SilviaAmAm our documentation needs updating, see comment from Erik

@vjawala
Copy link

vjawala commented Jun 12, 2024

Is it possible to re-add this feature, as the formio bug is closed?

@sergei-maertens
Copy link
Member

The upstream issue was closed because it was outdated, not because it was fixed. Additionally even if it was fixed, it's a mountain of work to upgrade to newer Formio versions since we had to patch a lot of things ourselves. Even upgrading to their latest 4.13.x patch release breaks Open Forms :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants