Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeating group shown by frontend logic with required fields gives error when filled in #2081

Closed
SilviaAmAm opened this issue Sep 27, 2022 · 3 comments · Fixed by #2105
Closed

Repeating group shown by frontend logic with required fields gives error when filled in #2081

SilviaAmAm opened this issue Sep 27, 2022 · 3 comments · Fixed by #2105
Assignees
@sergei-maertens
Labels
owner: den-haag
Milestone
Release 2.0.0

Comments

@SilviaAmAm
Copy link
Contributor

Product versie / Product version

2.0.0-beta.0

Omschrijf het probleem / Describe the bug

https://watch.screencastify.com/v/apSMwHSLyx14grX9WOyq

Stappen om te reproduceren / Steps to reproduce

Create a form with:

  • A radio button with values ja / nee
  • A fieldset with frontend logic that says: This field should show: True, if the component 'radio' has the value 'ja'.
  • Inside the fieldset a repeating group (always open first row checked)
  • Inside the repeating group a required textfield

Now fill in the form:

  • Click 'ja' in the radio
  • Try to fill in the text field, an error appears straight away

Verwacht gedrag / Expected behavior

No response

Screen resolution

No response

Device

No response

OS

No response

Browser

No response
@SilviaAmAm SilviaAmAm added this to the Release 2.0.0 milestone Sep 27, 2022
@SilviaAmAm SilviaAmAm self-assigned this Sep 27, 2022
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 27, 2022
@SilviaAmAm
🩹 [open-formulieren/open-forms#2081] Check if the submit is triggered…
70b45e8 
… by a submit button
@SilviaAmAm SilviaAmAm mentioned this issue Sep 27, 2022
Merged
@sergei-maertens
Copy link
Member

sergei-maertens commented Oct 4, 2022 •
edited
Loading

Looks like a bug in Formio - I could reproduce the behaviour on https://formio.github.io/formio.js/app/sandbox with Formio 4.12.7 (same version as used in SDK), and it seems fixed in 4.13.12

@sergei-maertens
Copy link
Member

Found the fix in formio: formio/formio.js@5fada97

This is pretty invasive and I don't want to (monkey) patch this, let's wait until Silvia is done with upgrading the internal formio version used in the SDK

@sergei-maertens
Copy link
Member

sergei-maertens commented Oct 4, 2022 •
edited
Loading

The saving/changing of the data in the first row is broken in Formio 4.13.x still, and also in 4.14.y :(

upstream issue: formio/formio.js#4620

sergei-maertens added a commit that referenced this issue Oct 4, 2022
@sergei-maertens
🩹 [#2081] -- Disable 'openWhenEmpty' feature in edit grid
9390509 
It's bugged in Formio, see formio/formio.js#4620
sergei-maertens added a commit that referenced this issue Oct 4, 2022
@sergei-maertens
🗃️ [#2081] -- add datamigration to convert existing edit grid components
150d625 
This disabled the 'openWhenEmpty' option retroactively.
@sergei-maertens sergei-maertens mentioned this issue Oct 4, 2022
Merged
@sergei-maertens sergei-maertens mentioned this issue Nov 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
owner: den-haag
Projects
None yet
Milestone
Release 2.0.0
Development

Successfully merging a pull request may close this issue.

Disable 'open first row when empty' functionality for repeating groups open-formulieren/open-forms
2 participants
@sergei-maertens @SilviaAmAm