Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Required" asterisk of repeating group seems out of place #2344

Closed
hlmr-erik opened this issue Nov 14, 2022 · 0 comments · Fixed by #2365
Closed

"Required" asterisk of repeating group seems out of place #2344

hlmr-erik opened this issue Nov 14, 2022 · 0 comments · Fixed by #2365
Assignees
@SilviaAmAm

Comments

@hlmr-erik
Copy link

hlmr-erik commented Nov 14, 2022 •
edited
Loading

Product versie / Product version

2.0.0

Omschrijf het probleem / Describe the bug

The asterisk to indicate that a repeating group is required is placed at quite a distance from the repeating group, making it seem out of place. A more logical location to me would seem next to its header. Alternatively, to place it as it is now, just closer to the repeating group.

image

  1. Next to header
    image

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

Screen resolution

1920 x 1080

Device

Desktop

OS

Windows

Browser

Firefox
@hlmr-erik hlmr-erik added bug triage Issue needs to be validated. Remove this label if the issue considered valid. labels Nov 14, 2022
@hlmr-erik hlmr-erik mentioned this issue Nov 14, 2022
Open
@SilviaAmAm SilviaAmAm self-assigned this Nov 17, 2022
@SilviaAmAm SilviaAmAm added haarlemmermeer and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Nov 17, 2022
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Nov 17, 2022
@SilviaAmAm
💄 [open-formulieren/open-forms#2344] Put asterisk next to repeating g…
5e6fc12 
…roup label
@SilviaAmAm SilviaAmAm mentioned this issue Nov 17, 2022
Merged
SilviaAmAm added a commit that referenced this issue Nov 17, 2022
@SilviaAmAm
💄 [#2344] Make hideLabel false
98eed69
SilviaAmAm added a commit that referenced this issue Nov 17, 2022
@SilviaAmAm
✨ [#2344] Add migration to change hideLabel setting
eab2b35
SilviaAmAm added a commit that referenced this issue Nov 17, 2022
@SilviaAmAm
✅ [#2344] Test migration
a62a9aa
@SilviaAmAm SilviaAmAm mentioned this issue Nov 17, 2022
Merged
sergei-maertens added a commit that referenced this issue Nov 17, 2022
@sergei-maertens
Merge pull request #2365 from open-formulieren/fix/2344-asterisk-plac…
98bc21d 
…ement

[#2344] Fix asterisk placement
CharString pushed a commit that referenced this issue Nov 23, 2022
@SilviaAmAm @CharString
💄 [#2344] Make hideLabel false
ae3faba
CharString pushed a commit that referenced this issue Nov 23, 2022
@SilviaAmAm @CharString
✨ [#2344] Add migration to change hideLabel setting
e612002
CharString pushed a commit that referenced this issue Nov 23, 2022
@SilviaAmAm @CharString
✅ [#2344] Test migration
d834b86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilviaAmAm SilviaAmAm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#2344] Fix asterisk placement open-formulieren/open-forms
2 participants
@SilviaAmAm @hlmr-erik