-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated explain command #779
Conversation
Various updates
I have just added a way to see which ontologies an axiom comes from in the markdown overview. Note this only works with real imports, not with the |
see #686 (comment) Another method for avoiding redundant explanations.
Added because missing for CI testing
I walked @cmungall through this PR and he is happy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
I have just added a way to see which ontologies an axiom comes from in the markdown overview.
Does this also work with the previous entailment mode?
It does! But only in the summary at the bottom. So for a 1 explanation scenario it will be redundant, but yes, you get that information! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall code looks good - see comments.
robot-command/src/main/java/org/obolibrary/robot/ExplainCommand.java
Outdated
Show resolved
Hide resolved
robot-core/src/main/java/org/obolibrary/robot/ExplainOperation.java
Outdated
Show resolved
Hide resolved
robot-core/src/main/java/org/obolibrary/robot/ExplainOperation.java
Outdated
Show resolved
Hide resolved
I converted this to draft to incorporate all of @beckyjackson feedback from the |
I tried updating the |
Sorry for the delay @matentzn. @beckyjackson Please merge when ready. |
Various updates
Resolves [#756, #329, #686]
docs/
have been added/updatedtests have been added/updated
mvn verify
says all tests pass <- cant runmvn site
says all JavaDocs correct <- cant run (seemvn site
fails because of some problem with DiffOperation #777)CHANGELOG.md
has been updatedThis pull request contains a number of changes to the explain command. The original command behaviour (which I refer to as
entailment
explanations) are untouched. See updated documentation for details.Summary of changes:
explain
and updated docs.To achieve the above, there are now two new options:
-M\--mode
: allows switching betweenentailment
(default),inconsistency
andunsatisfiablity
.-u\--unsatisfiable
: allows various fine grained options for generating explanations for unsatisfiable classes:all
(generate explanations for all unsats)root
(generate explanations for root unsats)random:n
subset (generate explanations forn
random unsatisfiable classes.uvular muscle SubClassOf Nothing
epimysium SubClassOf Nothing
skeletal muscle tissue SubClassOf Nothing
dense irregular connective tissue SubClassOf Nothing
skeletal muscle organ SubClassOf Nothing
palatal muscle SubClassOf Nothing
Axiom Impact
Axioms used 5 times
Axioms used 4 times
Axioms used 3 times
Axioms used 1 times
Ontologies used: