[ASAN] fix recursive initialization of sanitizer context #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AsanOptions class, a singleton, was being instantiated inside of the sanitizer context constructor, but, inside of its contructor, it was using the logger from inside of the context. This only worked before because the context variable was a global and the logger just so happened to be initialized prior to the AsanOptions. Now that the layer contexts are not globals, this was causing a deadlock on trying to retrieve a context while it was being initialized. The fix is to pass the logger manually to the AsanOptions class. A better fix might be to refactor AsanOptions to no longer be a static, but I was trying to minimize changes since this is blocking intel/llvm update.
github-actions
bot
added
loader
kbenzie
approved these changes
Jul 15, 2024
|
This is unrelated. I've seen this failing before a few times. |
|
@AllanZyne This was failing on intel/llvm CI after #1826, and we needed to quickly fix it. So we made a decision to merge this without waiting for your review. The changes are fairly small, but feel free to make a follow-up patch if you want to refactor this code. |
|
Thank you @pbalcer , We will make a follow-up PR for this later. |
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 16, 2024
smanna12
pushed a commit
to smanna12/llvm
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AsanOptions class, a singleton, was being instantiated inside of the sanitizer context constructor, but, inside of its contructor, it was using the logger from inside of the context. This only worked before because the context variable was a global and the logger just so happened to be initialized prior to the AsanOptions.
Now that the layer contexts are not globals, this was causing a deadlock on trying to retrieve a context while it was being initialized. The fix is to pass the logger manually to the AsanOptions class.
A better fix might be to refactor AsanOptions to no longer be a singleton, but I was trying to minimize changes since this is blocking intel/llvm update.