refactor loader lifetime management #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
pbalcer
force-pushed
the
loader-lifetime-context
branch
from
905a066
to
281f027
Compare
pbalcer
force-pushed
the
loader-lifetime-context
branch
6 times, most recently
from
a1f2402
to
9220498
Compare
kbenzie
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
I've been investigating tear down regression in intel/llvm#14145 and I believe this will solve those.
I'll be adding some logging on top of this once it merges for loading/unloader apdater libs to satisfy some e2e testing.
pbalcer
force-pushed
the
loader-lifetime-context
branch
3 times, most recently
from
31c3af8
to
4d1b56e
Compare
This patch implements an atomic singleton class for managing the lifecycle of the context objects inside of the loader. This class ensures that the contexts always exist and lets the loader manually destroy them on user request (during teardown). Thanks to this change, the loader no longer relies on the order of library constructors and destructors. It also gets us 90% towards allowing the loader to be statically linked with the application.
pbalcer
force-pushed
the
loader-lifetime-context
branch
from
4d1b56e
to
93f82f2
Compare
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 16, 2024
smanna12
pushed a commit
to smanna12/llvm
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements an atomic singleton class for managing the lifecycle of the context objects inside of the loader. This class ensures that the contexts always exist and lets the loader manually destroy them on user request (during teardown).
Thanks to this change, the loader no longer relies on the order of library constructors and destructors. It also gets us 90% towards allowing the loader to be statically linked with the application (which is why I did this :P).