[OpenCL] Add extension check for sub group sizes query #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check for `cl_intel_required_subgroup_size` extension. if the device does not have it a default value for sub group sizes list is returned.
kbenzie
reviewed
Jul 10, 2024
kbenzie
approved these changes
Jul 11, 2024
kbenzie
added a commit
that referenced
this pull request
Jul 15, 2024
Revert "Merge pull request #1849 from ayylol/cl-subgroupsizes"
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 16, 2024
smanna12
pushed a commit
to smanna12/llvm
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cl_intel_required_subgroup_sizeis needed to be able to check forCL_DEVICE_SUB_GROUP_SIZES_INTEL(See here). This patch adds a check for this extension, if it is not present a default sub group sizes list is returned.