Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scalebar units in PDF export #412

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

will-moore
Copy link
Member

Fixes #406

To test:

  • Add scalebars with different units to different images
  • Export as PDF
  • Check that units are shown correctly in info page:

Screenshot 2020-12-14 at 14 36 44

@jburel
Copy link
Member

jburel commented Jan 6, 2021

export option is disabled. is the export script on merge-ci?

@jburel
Copy link
Member

jburel commented Jan 7, 2021

tested using https://merge-ci.openmicroscopy.org/web/figure/file/64877
Screenshot 2021-01-07 at 16 16 41

The feature works, but the order of the scale bars does not corresponds to the order of the display
scale bar of the second image is first in the list

@will-moore
Copy link
Member Author

The images in a figure have no order (their position doesn't correspond to their order).
I collect the various scalebar lengths from all the images in the figure and only show each unique value, so it's likely that each scalebar applies to many images in different locations.
This export of scalebar lengths in the PDF was really needed before we had the ability to add labels to scalebars on the panels. Now that labels are supported (and will be the default with #413) the display of lengths in the PDF is not so important - and not worth spending too much time on improving (this is a bug-fix only).

@jburel
Copy link
Member

jburel commented Jan 8, 2021

thanks for the clarification. Merging

@jburel jburel merged commit a2661ef into ome:master Jan 8, 2021
@jburel jburel mentioned this pull request Feb 23, 2021
will-moore added a commit to will-moore/figure that referenced this pull request Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scalebar units in pdf wrong
2 participants