Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalebar show label by default #413

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

will-moore
Copy link
Member

The paper https://www.biorxiv.org/content/10.1101/2020.10.08.327718v1.full
mentioned in #407
has this advice about scalebars:

Annotate scale bar dimensions on the image: Stating the dimensions along with the scale bar allows readers to interpret the image more quickly.

This PR encourages users to add the label on the scale bar by showing the label by default.

To test:

  • Add a new Image panel
  • Add a scalebar - the label should be shown by default.
  • This won't change any existing figures where scale bars have been added to image panels already (even if the scale bar has subsequently been hidden) but if it's the first time that a scale bar has been added to a panel, the default 'show label' will apply.

@jburel
Copy link
Member

jburel commented Jan 6, 2021

  • remove the label
  • hide scale
  • tick label again
  • scale bar is shown.
    Is it the behaviour you were expected? since it is not mentioned in the description of this PR

The described workflow works

@will-moore
Copy link
Member Author

Yes, that behaviour is expected (not changed by this PR).
And the described workflow works. 👍

@jburel jburel merged commit 5f437b8 into ome:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants