-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strokeWidth handling #426
strokeWidth handling #426
Conversation
Looks good @will-moore sorry for missing the comments on #409. |
That last commit should also fix the cause of the issue: #427 |
Conflicting PR. Removed from build OMERO-plugins-push#684. See the console output for more details.
|
4395aef
to
67219f1
Compare
Created arrow, lines etc.:
|
I did not have any |
The |
@jburel You tested "Paste of crop region" steps OK? Not sure if you saw |
I did not have any "strokeWidth" in json when running the "Crop" test mentioned in the description. The way I read it I should have |
@jburel. Did you see the Rectangle created when you pasted the Crop region? |
Ok this is time, it works I must have done something incorrectly
|
merging |
This extends PR #409 (@emilroz), so that the Export script handles
shape.get('strokeWidth')
being a string everywhere.This PR also fixes the origin of the
strokeWidth
string...To test Export Script:
:0.75,
with"0.75",
everywhere.File > Export to JSON
you will see this.To test Paste of crop region:
Copy
the crop region on one panel (zoomed-in) andPaste
to create a new Rectangle ROI on a different Panel."strokeWidth":2
NOT"strokeWidth":"2"
.