Skip to content
This repository has been archived by the owner on Jan 26, 2025. It is now read-only.

Added string[] as valid type for scope in config #81

Closed
wants to merge 2 commits into from

Conversation

matthewstrom
Copy link

The actual JavaScript for OktaAuthModule accepts a string array for the scope property of the config; however, the faulty type definition causes compilation to fail when scope is an array.

@robertjd
Copy link
Contributor

Thanks for this PR! We’re actually trying to move to a world where scope is always defined as a string (per OAuth norms) so we want to leave this as a string. Ideally, we should only be checking for the only String type here. If you’d like to update this PR to remove that snippet instead, we will get this merged in ASAP!

@matthewstrom
Copy link
Author

Is that to say that a space-delimited list of scopes will work?

By "remove that snippet", are you proposing that line 162–165 in okta.service.ts should be removed? Won't that break backward compatibility?

Perhaps some better documentation is in order? Something that indicates that scope accepts a space-delimited list.

1 similar comment
@matthewstrom
Copy link
Author

Is that to say that a space-delimited list of scopes will work?

By "remove that snippet", are you proposing that line 162–165 in okta.service.ts should be removed? Won't that break backward compatibility?

Perhaps some better documentation is in order? Something that indicates that scope accepts a space-delimited list.

@cmckni3
Copy link

cmckni3 commented Feb 2, 2018

I modified the parameter of scrubScopes in #116. Do you want me to remove the string[] type and the related code @robertjd?

@robertjd robertjd added this to the 1.0.0 - Angular & Vue milestone Feb 14, 2018
@robertjd
Copy link
Contributor

Thanks all for pointing this out, in 1.0 we're going to make this string-only. See #120

@jmelberg-okta
Copy link
Contributor

This fix has been included with the 1.0.0 release of @okta/okta-angular See #157 and #167 for more details!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants