This repository has been archived by the owner on Jan 26, 2025. It is now read-only.
Remove array check on scopes #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmelberg-okta Are these pull requests going to be merged soon? |
|
Hi @cmckni3 , thank you for your active interest, your feedback is very useful for us as we iterate 👍 . We're collecting feedback on the current 0.x version of this library and starting to work towards a 1.0 release that will introduce any improvements as breaking changes. I can't guarantee a timeline but we are actively working on it this month. Please continue to watch the 1.0.0-angular branch, as that is where all changes will be merged. Once we have collected all desired changes for this major rev we will merge to master. If you have a fork that solves your needs I would continue using that for the time being. |
robertjd
approved these changes
Feb 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
scopespassed in as a custom parameter to be a singlestring.openid profile email custom['openid', 'profile', 'email', 'custom']