chore(typescript): Add better TypeScript definitions for Angular #116
Conversation
| return this.oktaAuth; | ||
| } | ||
|
|
||
| /** | ||
| * Checks if there is a current accessToken in the TokenManager. | ||
| */ | ||
| isAuthenticated() { | ||
| isAuthenticated(): boolean { | ||
| return !!this.oktaAuth.tokenManager.get('accessToken'); | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure what the type definitions of getAccessToken and getIdToken should be. Does @okta/okta-auth-js contain a structure for it?
BREAKING CHANGE
BREAKING CHANGE
There was a problem hiding this comment.
Thanks for taking on this task! 👊
Overall its looking pretty good! One simple ask - In our testing sample, can you make sure to reflect these changes under test/e2e/harness/src/app/app.module.ts? Then, verify this works by running npm start and/or npm test from the okta-angular directory. Thanks again!
packages/okta-react/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@okta/okta-react", | |||
| "version": "0.0.11", | |||
| "version": "0.0.12", | |||
There was a problem hiding this comment.
Since these versions are updated by our publishing script, can we make sure to revert this back before merging?
There was a problem hiding this comment.
Fixed. I had branched from master so there was an extra commit.
| @@ -0,0 +1,5 @@ | |||
| import { Router } from '@angular/router'; | |||
There was a problem hiding this comment.
Can you please add the license banner to this file? An example is available here.
|
Got it. Had to fix the type of
|
There was a problem hiding this comment.
Thanks @cmckni3!
My guess is npm test is failing because it is looking for specific environment variables. I was able to pull down your recent changes and can verify the tests pass. I've got a follow-up task to ensure we have proper documentation around this. Sorry about that!
Overall - everything looks good on my end. I'm tagging in @robertjd for one last look before we get this merged in.
|
sweet. Thanks, @jmelberg-okta! |
jmelberg-okta
force-pushed
the
1.0.0-angular
branch
2 times, most recently
from
fedb7bc to
f47170b
Compare
jmelberg-okta
force-pushed
the
1.0.0-angular
branch
from
01f2498 to
79280a7
Compare
No description provided.