-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use common code for constellix API interaction, prepare auth for v4 #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems good. Couple comments/questions inline.
Will hold off merging until you say so.
Looks good. Will hold clicking the green button until you say so. Any interest in having commit/merge access? Either temporarily or permanently? For this repo or the org? You've been involved enough at this point that it probably make sense, but up to you. The only requirements are that you show up every now and then and review stuff for others and get reviews from others for anything nontrival or potentially impactful. |
Thank you. Go for it, I checked against the real API and it works for me.
Thanks for the offer - it is an honor. If you think it makes sense, I could see myself doing a little more maintenance on this one. As for the other providers, I only really use However, feel free to add me as a regular reviewer (w/o write access) for the org. Before making any of these changes, please ask the rest of the org if there are any objections. 😃 |
You should have the perms once the invite has been accepted. |
@ross OK, thank you. Could you please guide me on the merge policies for
|
Std practice is the GitHub default "Create a merge commit." This basically follows GitHub Flow as practiced internally. PR is the main source of general history and the commits show the details of how things got there (and aren't linear or anything.)
CHANGELOG.md updates are manual. Can be done in a stand-alone commit or as part of one of the final commits of the branch.
Process is a commit & PR that updates Once the PR is reviewed it's merged normally and...
The repos have For now you (or anyone else who wants a release of something) can just open the PR in the repo I can merge and release (hit by a bus-wise I'm not the only one w/perms 😁) |
@ross ok, I'll then leave the versioning and publication up to you. I thought that publishing would be done using some "automagic" interaction between commit tags and github actions. |
I thought about looking into something like |
Fixes #41.