Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: de-duplicate API code #41

Closed
istr opened this issue Oct 14, 2023 · 0 comments · Fixed by #42
Closed

Refactor: de-duplicate API code #41

istr opened this issue Oct 14, 2023 · 0 comments · Fixed by #42

Comments

@istr
Copy link
Contributor

istr commented Oct 14, 2023

Currently, the ConstellixClient and the SonarClient share similar, but not identical code to communicate with the Constellix APIs.

Refactor the code to use a common ConstellixAPI base class for both, prepared for the new v4 API with Authentication: Bearer instead of the custom authZ header.
https://api.dns.constellix.com/v4/docs#section/Authentication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use common code for constellix API interaction, prepare auth for v4 istr/octodns-constellix
1 participant
@istr