totalLockedValue [sic] is a fantasy number

[kremalicious]

This query returns as totalLockedValue:

OCEAN 608499837

which would be converted:

€ 287,748,011

We do not have 287 Million Euro locked in our pools. So it's completely wrong.

---

(And it should be totalValueLocked not totalLockedValue. Already commented in the PR)

[trentmc]

As a matter of process: why is this a new issue, rather than a comment in the issue & PR for bringing in TVL?

Also note: it should be "TVL" not "TLV". I've commented in the PR, but I'm commenting here to help ensure that the mistake doesn't propagate:)

[kremalicious]

because this is the place where it needs to be solved so it's an issue here. Issues should exist on the projects where they are actually solved, no backend dev gets active cause we add a comment on some market PR. This here is clearly backend, so it's also not up to market devs to fix this somehow on the market (we simply can't), we are blocked by it. And the PR oceanprotocol/market#353 then states in its description that it is blocked by this. totalLockedValue is how it is called in multiple places here in this repo in the code right now, it's the current reality.

So that would be another issue to create in this repo to make sure to change all those keys: https://github.com/oceanprotocol/ocean-subgraph/search?q=totalLockedValue. I would suggest creating a new issue for that instead of mixing it up with actually fixing the number.

By now, we have a responsibility problem in this repo which is almost abandoned because we consider certain enterprise work to be more important given that it takes more than 25 days to approve and merge the most basic PRs: #6

[mihaisc]

As soon as we merge both PRs (#6 and #17, they are prio for me now ) i'll take a look at this

[kremalicious]

so the fix for this was combined in #6 and not in separate PR, right? Did the rename of the key happen too?

And if it was fixed in there, is it also deployed? Are we using the actual documented release process? https://github.com/oceanprotocol/ocean-subgraph#%EF%B8%8F-releases

[mihaisc]

It includes the rename but it was not deployed yet, will check and close the issue.
We are using it but the release is done on each env ( in aws), it can't be automated for now.

[kremalicious]

yup, know the full deployments can't be that easily automated but we should still do a release with a changelog right before doing deployment. Then it's clear to users which version of code is deployed, and what changed. Like, renaming that key is a breaking change, but there's not even a commit message for it. Using PRs and npm run release will do that