Display TVL

[claudiaHash]

Fixes #286 .

Changes proposed in this PR:

• tvl value fetched from graph
• converted tvl (ocean) to selected currency
• tvl displayed in footer stats

---

blocked by oceanprotocol/ocean-subgraph#16

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/oceanprotocol/market/8mdu8knfg
✅ Preview: https://market-git-feature-display-tlv.oceanprotocol.now.sh

[kremalicious]

#354 should help so we do not have to deal with formatting errors in the future

[kremalicious]

Blocked by oceanprotocol/ocean-subgraph#16

Any other blockers for this PR from the data source?

[claudiaHash]

Blocked by oceanprotocol/ocean-subgraph#16

Any other blockers for this PR from the data source?

Nothing, as far as I know.

[kremalicious]

think we can get this already implemented with suggested changes, and where we assume correct numbers from the subgraph so we end up with only this sentence as mentioned here:

€1,209,894.27 TVL across 156 dataset pools that contain 1,095,651.439 OCEAN and the datatokens for each pool.

So that as soon as oceanprotocol/ocean-subgraph#16 is fixed we can release this here.

[kremalicious]

Yeah, think everything monetary seems correct! Thanks for fixing that Apollo setup, seems to not make the typical problems with SSR

Comparison for reference for current numbers, where purgatory assets are excluded:

What's up with the high pool number?

[mihaisc]

Looking at this query there actually are.

[kremalicious]

new reference with finalizedPoolCount, much more realistic considering the purgatory assets counted in it

Is this the correct place for using an Oxford comma? Or is it clear that number of datatokens is not the same number as OCEAN?

...that contain 1,119,869.616 OCEAN, and datatokens for each pool.

Albeit technically correct, from usability standpoint it stays a bit confusing when comparing data set numbers from searches. Might be good place to have some tooltip explaining this number slightly.

Proposed text, with tooltip trigger placed at very end of sentence:

Counted on-chain from our pool factory. Does not filter out data sets in list-purgatory.

too specific?

[mihaisc]

You lost me with the comma. Before i never had a doubt when reading it, now i am wondering...
Good idea with the tooltip, always good to be transparent with the data

[claudiaHash]

should the icon be smaller?

[kremalicious]

could be, but could also look alright if we put the icon at the end of sentence, since tooltip info concerns all numbers. Forgot if that's possible with our tooltips, but can we link list-purgatory to the repo?

[kremalicious]

network switching works super well too. But did not test against barge yet, will do that tomorrow. Cause then we'll have a subgraphUri: null, so want to make sure this doesn't break whole app https://github.com/oceanprotocol/ocean.js/blob/main/src/utils/ConfigHelper.ts#L43

[mihaisc]

Another option would be to specifically add the provider where we need it ( AssetActions, Footer, History )

[mihaisc]

Update : I blocked subgraph.mainnet.oceanprotocol.com and tested the website. Works fine, just the stuff from the graph doesn't load so I think we are ok




Maybe we create a component that monitors the status of our services ( not related to this PR )

[kremalicious]

phew, got it, local barge development was broken cause the handleNetworkChange in network monitor never fired, so subgraphUri was never overwritten, resulting in ApolloClient never getting initiated, which then broke things. Pushing fix in a second

[kremalicious]

Another option would be to specifically add the provider where we need it ( AssetActions, Footer, History )

also thought about that but think it's worth figuring it out globally:

• we do not have to deal with the Apollo setup again in all future The Graph work
• we do not constantly unmount and mount the provider on route changes

Putting it in Gatsby's wrapRootComponent should make sure of both, but it also requires us to always test the deployed version because locally there's no SSR build. But seems to be all working well now

[kremalicious]

final before/after reference snapshots, think that's shippable if everybody agrees on the validity of all numbers:

[trentmc]

think that's shippable if everybody agrees on the validity of all numbers:

+1 from my side

[trentmc]

As commented in slack: Rather than "OCEAN and datatokens for each", I'd say "OCEAN, plus datatokens for each"

[kremalicious]

great! What a journey to get 3 numbers in the end