-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Number of datatokens" displayed in the market footer is meaningless/confusing; TVL would be super-useful #286
Comments
trentmc
changed the title
Remove the number of datatokens displayed in the market footer
"Number of datatokens" displayed in the market footer is meaningless/confusing
Jan 12, 2021
Following the discussion in the PR #311, we agree that only once we output TVL, the number of datatokens becomes meaningless. Updated the issue with that new proposed statistics line |
trentmc
changed the title
"Number of datatokens" displayed in the market footer is meaningless/confusing
"Number of datatokens" displayed in the market footer is meaningless/confusing; TVL would be super-useful
Jan 12, 2021
6 tasks
Note: Samer says we have TVL in TheGraph. So this just needs to get put into Ocean Market. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Ocean Market footer currently shows e.g. "1,298,989.836 OCEAN≈ €502,197.26 and 40,107.252 datatokens in 167 data set pools."
The part "40,107.252 datatokens" is meaningless. It's like giving a stat for "# BTC tokens" + "# ETH tokens" + "# XRP tokens" + ... . Each token has a different value / meaning. This does not help users, and can actually confuse them as they try to sort out what it might mean.
This is precious real estate. There are plenty of stats that are more useful. E.g. min/avg/max # consumes per dataset, min/avg/max OCEAN price per dataset, min/avg/max OCEAN liquidity per dataset. And more.
[Originally proposed] TODO for this ticket: simply remove the part that gives "40,107.252 datatokens".
[Updated proposed] TODO for this ticket: Update the footer to give information that accounts for the value of the datatokens (and doesn't show "number of datatokens"). Full proposal is a comment in this PR: #311 (comment)
Spec
Replace current footer statistics line with:
The text was updated successfully, but these errors were encountered: