Activate dependabot, build tweaks, green CI #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kremalicious
force-pushed
the
feature/dependabot
branch
from
4982a3b to
abbc866
Compare
kremalicious
force-pushed
the
feature/dependabot
branch
from
abbc866 to
d5357e3
Compare
kremalicious
force-pushed
the
feature/dependabot
branch
from
c8affec to
b22cd82
Compare
kremalicious
commented
Jan 26, 2021
This was referenced Feb 2, 2021
Closed
kremalicious
changed the title
|
If no one has any comments i'll merge this today/tomorrow |
mihaisc
previously approved these changes
Feb 9, 2021
|
|
|
We can't merge before testing deployment on a local node. |
|
I agree, as long as there are changes in the actual code (src/). We need to test it first |
* improve developer docs * fix readme Signed-off-by: mihaisc <mihai.scarlat@smartcontrol.ro> * update gitignore Signed-off-by: mihaisc <mihai.scarlat@smartcontrol.ro> * .env, and infura key Signed-off-by: mihaisc <mihai.scarlat@smartcontrol.ro> Co-authored-by: mihaisc <mihai.scarlat@smartcontrol.ro>
|
Will test on rinkeby |
# Conflicts: # README.md # src/helpers.ts # src/mappings/pool.ts
Closed
* Update the readme file. * Add totalOceanLiquidity and fix TVL calculation * add logs to track pool shares. * update variable names * fix error after merge Co-authored-by: ssallam <travis@travis-ci.org>
|
Tested on Rinkeby (using local graph-node), seems to work. |
added 2 commits
February 9, 2021 11:09
…/dependabot # Conflicts: # src/helpers.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/@typessrc/@types/&build/togitignoreeqeqeqESLint rule, because The Graph relies on the non-best practice usage of itextendsActually making use of type checking stays broken since https://github.com/graphprotocol/graph-ts/issues/113 seems still not solved
closes #11