-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Need a way to block on segment initialization #68
Comments
It is not safe to assume that every segment defined in a pipeline will be instantiated. If the primary motivation here is to generate a viz file, we should be able to do it from the pipeline definition and proto serialization; however, in the case of python, we not be able to generate full type information. |
@ryanolson doesn't calling |
For the standalone / single node executor, that is indeed what happens. But it is not generally true. If you had a two segment, two machine pipeline with segment A on machine A and segment B on machine B, the local executor would only ever construct/initialize A or B. |
From Morpheus' perspective then, we would always know which specific segment we are interested in. So in the above example:
|
I agree with @ryanolson. You never know if the initializer is going to be called or not. The only thing you can do is await on I think we should close this issue as wontfix. The better solution is to handle this in morpheus with nv-morpheus/Morpheus#84 |
Adds a busy-loop to block until pipeline build is completed. Fixes #188 Ideally nv-morpheus/MRC#68 would provide a better way to do this. Authors: - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #203
Is your feature request related to a problem? Please describe.
In Morpheus we need a way to block until the segment initializer has been called.
nv-morpheus/Morpheus#188
Currently Morpheus is building the pipeline with:
The problem is that
inner_build
is called asynchronously and we need a way to wait until afterinner_build
is called.Describe the solution you'd like
Probably some sort of blocking call that we can make like:
wait_for_segment_init
Additional context
In Morpheus we don't have the full detail of the messages passed between nodes until the pipeline is fully built, which doesn't happen until the segment initialize is called.
The text was updated successfully, but these errors were encountered: