Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Separate Pipeline Type Inference from Node Creation #84

Closed
mdemoret-nv opened this issue May 5, 2022 · 1 comment
Closed

[FEA] Separate Pipeline Type Inference from Node Creation #84

mdemoret-nv opened this issue May 5, 2022 · 1 comment
Assignees
Labels
feature request New feature or request

Comments

@mdemoret-nv
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, morpheus determines the input/output types of each stage at the same time the nodes are created. This is a relic of the streamz days and requires the _build() methods to accept and return tuples of StreamPair. This is an ugly implementation delays type checking until the pipeline is actually being created.

Describe the solution you'd like
Before the pipeline object is created, Morpheus should run type inference on all stages to determine their input/output types. This will separate the two pieces and allow for invalid pipelines to be checked before any nodes are created.

@mdemoret-nv
Copy link
Contributor Author

Closing in favor of #229

@mdemoret-nv mdemoret-nv closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants