Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Pipeline.visualize method unable to determine message types between stages #188

Closed
dagardner-nv opened this issue Jun 24, 2022 · 1 comment · Fixed by #203
Closed

[BUG] Pipeline.visualize method unable to determine message types between stages #188

dagardner-nv opened this issue Jun 24, 2022 · 1 comment · Fixed by #203
Assignees
@dagardner-nv
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Describe the bug
As discussed in #147 adding the --viz_file flag to the morpheus cli causes a crash as Pipeline.visualize will send a None into type_utils.

Steps/Code to reproduce bug
Add the --viz_file flag to any of the cli pipelines.

Expected behavior
Not crashing.
@dagardner-nv dagardner-nv added bug Something isn't working Needs Triage Need team to review and classify and removed Needs Triage Need team to review and classify labels Jun 24, 2022
@dagardner-nv dagardner-nv mentioned this issue Jun 24, 2022
Merged
@dagardner-nv dagardner-nv self-assigned this Jun 25, 2022
@dagardner-nv
Copy link
Contributor Author

I spent a little time looking into this one.
The issue is that the type information for the edges is only known after the pipeline is built. Prior to that Receiver.in_type and Sender.out_type are both None.

The problem is that under the hood much of the build process is performed asynchronously. In Morpheus we don't have a way to block on build completion.

This was referenced Jun 25, 2022
Closed
Closed
Merged
@ghost ghost closed this as completed in #203 Jun 28, 2022
ghost pushed a commit that referenced this issue Jun 28, 2022
@dagardner-nv
Fixes Pipeline.visualize (#203)
ec8afcd 
Adds a busy-loop to block until pipeline build is completed.
Fixes #188

Ideally nv-morpheus/MRC#68 would provide a better way to do this.

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #203
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Pipeline.visualize dagardner-nv/Morpheus
Fixes Pipeline.visualize dagardner-nv/Morpheus
1 participant
@dagardner-nv