Filled background color for "Find" widget's button toggle active state #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In VS Code 1.37 (1) (July 2019) the Find widget's button toggle active state now has a filled background so that it is easier to tell when the focus is on an active toggle. To customize the background color of the toggle active state, the new `inputOption.activeBackground` UI/workbench theme key has been added to Nord. Unfortunately there is no UI theme key to also change the foreground color of active state toggles. It is "hard-coded" using a relatively bright color so it is not possible to also use a bright background color. It would be great to apply a "reverse" effect to e.g. use `nord0` as foreground to increase the contrast when using `nord8` as background color. References: (1) https://code.visualstudio.com/updates/v1_37#_button-toggle-active-state-in-find-widget GH-151
svengreb
approved these changes
Aug 10, 2019
arcticicestudio
deleted the
feature/gh-151-filled-bavkground-color-active-find-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After