Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filled background color for "Find" widget's button toggle active state #151

Closed
arcticicestudio opened this issue Aug 10, 2019 · 0 comments · Fixed by #153
Closed

Filled background color for "Find" widget's button toggle active state #151

arcticicestudio opened this issue Aug 10, 2019 · 0 comments · Fixed by #153

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Aug 10, 2019

In VS Code 1.37 (July 2019) the Find widget's button toggle active state now has a filled background so that it is easier to tell when the focus is on an active toggle.

To customize the background color of the toggle active state, the new inputOption.activeBackground UI/workbench theme key will be added to Nord.

Unfortunately there is no UI theme key (yet) to also change the foreground color of active state toggles. It is "hard-coded" using a relatively bright color so it is not possible to also use a bright background color. It would be great to apply a "reverse" effect to e.g. use nord0 as foreground to increase the contrast when using nord8 as background color.

@arcticicestudio arcticicestudio added this to the 0.12.0 milestone Aug 10, 2019
@arcticicestudio arcticicestudio self-assigned this Aug 10, 2019
arcticicestudio added a commit that referenced this issue Aug 10, 2019
In VS Code 1.37 (1) (July 2019) the Find widget's button toggle active
state now has a filled background so that it is easier to tell when the
focus is on an active toggle.

To customize the background color of the toggle active state, the new
`inputOption.activeBackground` UI/workbench theme key has been added to
Nord.

Unfortunately there is no UI theme key to also change the foreground
color of active state toggles. It is "hard-coded" using a relatively
bright color so it is not possible to also use a bright background
color. It would be great to apply a "reverse" effect to e.g. use
`nord0` as foreground to increase the contrast when using `nord8`
as background color.

References:
  (1) https://code.visualstudio.com/updates/v1_37#_button-toggle-active-state-in-find-widget

GH-151
arcticicestudio added a commit that referenced this issue Aug 10, 2019
In VS Code 1.37 (1) (July 2019) the Find widget's button toggle active
state now has a filled background so that it is easier to tell when the
focus is on an active toggle.

To customize the background color of the toggle active state, the new
`inputOption.activeBackground` UI/workbench theme key has been added to
Nord.

Unfortunately there is no UI theme key to also change the foreground
color of active state toggles. It is "hard-coded" using a relatively
bright color so it is not possible to also use a bright background
color. It would be great to apply a "reverse" effect to e.g. use
`nord0` as foreground to increase the contrast when using `nord8`
as background color.

References:
  (1) https://code.visualstudio.com/updates/v1_37#_button-toggle-active-state-in-find-widget

Resolves GH-151
@arcticicestudio arcticicestudio removed their assignment Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant