Skip to content

Commit

Permalink
Filled background color for "Find" widget's button toggle active… (#153)
Browse files Browse the repository at this point in the history
In VS Code 1.37 (1) (July 2019) the Find widget's button toggle active
state now has a filled background so that it is easier to tell when the
focus is on an active toggle.

To customize the background color of the toggle active state, the new
`inputOption.activeBackground` UI/workbench theme key has been added to
Nord.

Unfortunately there is no UI theme key to also change the foreground
color of active state toggles. It is "hard-coded" using a relatively
bright color so it is not possible to also use a bright background
color. It would be great to apply a "reverse" effect to e.g. use
`nord0` as foreground to increase the contrast when using `nord8`
as background color.

References:
  (1) https://code.visualstudio.com/updates/v1_37#_button-toggle-active-state-in-find-widget

Resolves GH-151
  • Loading branch information
arcticicestudio authored Aug 10, 2019
1 parent 6b6655f commit f5c767f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion themes/nord-color-theme.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@
"input.foreground": "#d8dee9",
"input.placeholderForeground": "#d8dee999",
"input.border": "#3b4252",
"inputOption.activeBorder": "#88c0d0",
"inputOption.activeBackground": "#5e81ac",
"inputOption.activeBorder": "#5e81ac",
"inputValidation.errorBackground": "#bf616a",
"inputValidation.errorBorder": "#bf616a",
"inputValidation.infoBackground": "#81a1c1",
Expand Down

0 comments on commit f5c767f

Please sign in to comment.