stream: validate undefined sizeAlgorithm in WritableStream #56067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56067 +/- ##
=======================================
Coverage 88.00% 88.00%
=======================================
Files 656 656
Lines 188988 188997 +9
Branches 35992 35991 -1
=======================================
+ Hits 166315 166324 +9
+ Misses 15838 15832 -6
- Partials 6835 6841 +6
|
github-actions
bot
removed
the
request-ci
jakecastelli
approved these changes
Dec 16, 2024
jakecastelli
added
the
author ready
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 57b21b1 |
aduh95
pushed a commit
that referenced
this pull request
Jan 2, 2025
PR-URL: #56067 Fixes: #56014 Refs: whatwg/streams#1333 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No test was added since it was covered by existing WPT, and the spec change did not introduce WPT updates
Fixes: #56014
Refs: whatwg/streams#1333