Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use unusual chars in the path to ensure our tests are robust #48409

Merged
merged 13 commits into from
Dec 30, 2024
Merged

test: use unusual chars in the path to ensure our tests are robust #48409

merged 13 commits into from
Dec 30, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 10, 2023

Hopefully our tests should work without assuming the repo is cloned in path that contains unusual chars.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 10, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 10, 2023

TIL GNU Make does not support files containing whitespaces nor %, that's… unexpected.

@targos
Copy link
Member

targos commented Jun 25, 2023 •
edited
Loading

Should we maybe avoid the hidden characters? I guess it's ok if GH only warns about them now but I don't want to see a permanent warning on the repo.

@aduh95
Copy link
Contributor Author

aduh95 commented Jun 25, 2023

Should we maybe avoid the hidden characters? I guess it's ok if GH only warns about them now but I don't want to see a permanent warning on the repo.

I'm pretty sure it's just about the branch name for this PR, not related to the content of this PR.

console.log("\u2020\u00A3\u00A7\u2122" === '†£§™'); // true

@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (48c75bc) to head (55edf5d).
Report is 30 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #48409   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files         657      657           
  Lines      190395   190395           
  Branches    36552    36550    -2     
=======================================
+ Hits       168580   168590   +10     
+ Misses      14993    14986    -7     
+ Partials     6822     6819    -3

see 35 files with indirect coverage changes

@aduh95 aduh95 force-pushed the †£§™ branch 3 times, most recently from a5e5921 to c8b19c2 Compare September 25, 2024 22:12
@aduh95 aduh95 force-pushed the †£§™ branch 2 times, most recently from 78ec699 to 1c336ad Compare September 29, 2024 21:26
@aduh95 aduh95 force-pushed the †£§™ branch 3 times, most recently from 34bafc0 to 522b401 Compare October 22, 2024 08:28
@aduh95 aduh95 mentioned this pull request Oct 22, 2024
Merged
@aduh95 aduh95 mentioned this pull request Dec 17, 2024
Merged
RafaelGSS
RafaelGSS reviewed Dec 17, 2024
View reviewed changes
.github/workflows/test-linux.yml
- name: Test
run: make run-ci -j4 V=1 TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' --measure-flakiness 9"
run: make -C node run-ci -j4 V=1 TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' --measure-flakiness 9"
- name: Re-run test in a folder whose name contains unusual chars
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it mean we'll double the time to run the tests in the GH Actions?

Copy link
Contributor Author

@aduh95 aduh95 Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you see in this PR, it adds about 10 minutes (a bit less on Linux)

@aduh95 aduh95 mentioned this pull request Dec 18, 2024
Closed
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64156/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64175/

JakobJingleheimer
JakobJingleheimer approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2024
@nodejs-github-bot nodejs-github-bot merged commit d2af881 into nodejs:main Dec 30, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d2af881

Tiffanyscott

This comment was marked as off-topic.

Sign in to view

@aduh95 aduh95 deleted the †£§™ branch December 30, 2024 00:23
aduh95 added a commit that referenced this pull request Jan 2, 2025
@aduh95
test: use unusual chars in the path to ensure our tests are robust
510649f 
PR-URL: #48409
Reviewed-By: Jacob Smith <jacob@frende.me>
@github-actions github-actions bot mentioned this pull request Jan 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tiffanyscott Tiffanyscott Tiffanyscott left review comments

@avivkeller avivkeller avivkeller left review comments

@RafaelGSS RafaelGSS RafaelGSS left review comments

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @nodejs-github-bot @targos @JakobJingleheimer @RafaelGSS @avivkeller @Tiffanyscott