Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove test-worker-arraybuffer-zerofill flaky designation #56364

Merged
merged 1 commit into from
Dec 28, 2024
Merged

test: remove test-worker-arraybuffer-zerofill flaky designation #56364

merged 1 commit into from
Dec 28, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Dec 25, 2024

Refs: #56053

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 25, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.56%. Comparing base (821b0a7) to head (a1f748f).
Report is 29 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56364   +/-   ##
=======================================
  Coverage   88.55%   88.56%           
=======================================
  Files         657      657           
  Lines      190655   190655           
  Branches    36584    36580    -4     
=======================================
+ Hits       168838   168850   +12     
+ Misses      15001    14993    -8     
+ Partials     6816     6812    -4

see 23 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64208/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64213/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64218/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64221/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 28, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7d7e2ce into nodejs:main Dec 28, 2024
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7d7e2ce

@lpinca lpinca deleted the remove/flaky-test-worker-arraybuffer-zerofill branch December 28, 2024 07:50
aduh95 pushed a commit that referenced this pull request Jan 2, 2025
@lpinca @aduh95
test: remove test-worker-arraybuffer-zerofill flaky designation
20ace0b 
Refs: #56053
PR-URL: #56364
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Jan 2, 2025
@github-actions github-actions bot mentioned this pull request Jan 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecastelli jakecastelli jakecastelli approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lpinca @nodejs-github-bot @jasnell @jakecastelli @aduh95