Release proposal: v5.2.0 (Stable) #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/release I've just made a As of now it only shows commits that don't have |
mscdex
added
the
meta
rvagg
force-pushed
the
v5.2.0-proposal
branch
from
9f34df8 to
8c47894
Compare
|
thanks @bnoordhuis, great to see that land. I've included it now and assume the changes to |
|
https://ci.nodejs.org/job/node-test-commit/1377/ pretty solid atm |
|
Here's my Notable changes section:
Please review @cdai2, @indutny, @mruddy, @bnoordhuis, @matthewloring |
rvagg
force-pushed
the
v5.2.0-proposal
branch
from
8c47894 to
58f0a77
Compare
| - Add support for Intel's VTune JIT profiling when compiled with `--enable-vtune-profiling`. For more information about VTune, see <https://software.intel.com/en-us/node/544211>. (Chunyang Dai) [#3785](https://github.com/nodejs/node/pull/3785). | ||
| - Properly enable V8 snapshots by default. Due to a configuration error, snapshots have been kept off by default when the intention is for the feature to be enabled. (Fedor Indutny) [#3962](https://github.com/nodejs/node/pull/3962). | ||
| * **crypto**: | ||
| - Generate a public key when explicitly setting a private key for ECDH (Elliptic Curve Diffie-Hellman) exchange objects (created via `crypto.createECDH(curve_name)`). Also deprecated the `setPublicKey()` method for ECDH objects as this can lead to an inconsistent state. The validity of the keypair is now checked when setting a private key. (Michael Ruddy) [#3511](https://github.com/nodejs/node/pull/3511). |
There was a problem hiding this comment.
What you have is good/usable. I'd say it like the following (but, no big deal if you want to use what you have):
Simplifies using ECDH (Elliptic Curve Diffie-Hellman) objects with private keys that are not dynamically generated via generateKeys(). The public key is now computed when explicitly setting a private key. Added validity checks to reduce the possibility of computing weak or invalid shared secrets. Also, deprecated the setPublicKey() method for ECDH objects as its usage is unnecessary and can lead to inconsistent state. (Michael Ruddy) #3511.
There was a problem hiding this comment.
thanks @mruddy, that's perfect so I'm going with your wording
|
LGTM |
rvagg
force-pushed
the
v5.2.0-proposal
branch
2 times, most recently
from
7782aac to
275243b
Compare
|
Added to crypto:
|
rvagg
force-pushed
the
v5.2.0-proposal
branch
from
275243b to
bcc05b5
Compare
|
CI @ https://ci.nodejs.org/job/node-test-commit/1395/ Building @ https://ci.nodejs.org/job/iojs+release/319/, will move on to some further smoke testing before releasing |
rvagg
force-pushed
the
v5.2.0-proposal
branch
from
bcc05b5 to
889acc1
Compare
Notable changes:
* build:
- Add support for Intel's VTune JIT profiling when compiled with
--enable-vtune-profiling. For more information about VTune, see
https://software.intel.com/en-us/node/544211. (Chunyang Dai) #3785.
- Properly enable V8 snapshots by default. Due to a configuration
error, snapshots have been kept off by default when the intention
is for the feature to be enabled. (Fedor Indutny) #3962.
* crypto:
- Simplify use of ECDH (Elliptic Curve Diffie-Hellman) objects
(created via crypto.createECDH(curve_name)) with private keys that
are not dynamically generated via generateKeys(). The public key
is now computed when explicitly setting a private key. Added
validity checks to reduce the possibility of computing weak or
invalid shared secrets. Also, deprecated the setPublicKey() method
for ECDH objects as its usage is unnecessary and can lead to
inconsistent state. (Michael Ruddy) #3511.
- Update root certificates from the current list stored maintained
by Mozilla NSS. (Ben Noordhuis) #3951.
- Multiple CA certificates can now be passed with the ca option to
TLS methods as an array of strings or in a single new-line
separated string. (Ben Noordhuis) #4099
* tools: Include a tick processor in core, exposed via the
--prof-process command-line argument which can be used to process V8
profiling output files generated when using the --prof command-line
argument. (Matt Loring) #4021.
PR-URL: #4181
rvagg
force-pushed
the
v5.2.0-proposal
branch
from
889acc1 to
65b86c0
Compare
|
a couple of very minor typos in the changelog and commit message, not in a hurry so rebuilding, will release as soon as it's done, tests are all 👍 |
rvagg
added a commit
that referenced
this pull request
Dec 9, 2015
Notable changes:
* build:
- Add support for Intel's VTune JIT profiling when compiled with
--enable-vtune-profiling. For more information about VTune, see
https://software.intel.com/en-us/node/544211. (Chunyang Dai) #3785.
- Properly enable V8 snapshots by default. Due to a configuration
error, snapshots have been kept off by default when the intention
is for the feature to be enabled. (Fedor Indutny) #3962.
* crypto:
- Simplify use of ECDH (Elliptic Curve Diffie-Hellman) objects
(created via crypto.createECDH(curve_name)) with private keys that
are not dynamically generated via generateKeys(). The public key
is now computed when explicitly setting a private key. Added
validity checks to reduce the possibility of computing weak or
invalid shared secrets. Also, deprecated the setPublicKey() method
for ECDH objects as its usage is unnecessary and can lead to
inconsistent state. (Michael Ruddy) #3511.
- Update root certificates from the current list stored maintained
by Mozilla NSS. (Ben Noordhuis) #3951.
- Multiple CA certificates can now be passed with the ca option to
TLS methods as an array of strings or in a single new-line
separated string. (Ben Noordhuis) #4099
* tools: Include a tick processor in core, exposed via the
--prof-process command-line argument which can be used to process V8
profiling output files generated when using the --prof command-line
argument. (Matt Loring) #4021.
PR-URL: #4181
|
built, tagged, promoted and announced, http://nodejs.org/en/blog/release/v5.2.0/ & https://nodejs.org/download/release/v5.2.0/, thanks all, on to v5.2.1 |
Starefossen
pushed a commit
to Starefossen/official-images
that referenced
this pull request
Dec 9, 2015
Related: nodejs/node#4181 Related: nodejs/docker-node#76 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
Closed
Closed
pierreozoux
pushed a commit
to pierreozoux/official-images
that referenced
this pull request
Jan 7, 2016
Related: nodejs/node#4181 Related: nodejs/docker-node#76 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Notable changes:
* build:
- Add support for Intel's VTune JIT profiling when compiled with
--enable-vtune-profiling. For more information about VTune, see
https://software.intel.com/en-us/node/544211. (Chunyang Dai) nodejs#3785.
- Properly enable V8 snapshots by default. Due to a configuration
error, snapshots have been kept off by default when the intention
is for the feature to be enabled. (Fedor Indutny) nodejs#3962.
* crypto:
- Simplify use of ECDH (Elliptic Curve Diffie-Hellman) objects
(created via crypto.createECDH(curve_name)) with private keys that
are not dynamically generated via generateKeys(). The public key
is now computed when explicitly setting a private key. Added
validity checks to reduce the possibility of computing weak or
invalid shared secrets. Also, deprecated the setPublicKey() method
for ECDH objects as its usage is unnecessary and can lead to
inconsistent state. (Michael Ruddy) nodejs#3511.
- Update root certificates from the current list stored maintained
by Mozilla NSS. (Ben Noordhuis) nodejs#3951.
- Multiple CA certificates can now be passed with the ca option to
TLS methods as an array of strings or in a single new-line
separated string. (Ben Noordhuis) nodejs#4099
* tools: Include a tick processor in core, exposed via the
--prof-process command-line argument which can be used to process V8
profiling output files generated when using the --prof command-line
argument. (Matt Loring) nodejs#4021.
PR-URL: nodejs#4181
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
Related: nodejs/node#4181 Related: nodejs/docker-node#76 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since others seem to be busy with Node Interactive and this is long overdue, here's a proposal for release maybe as soon as tomorrow.
Commits list could do with some review, is there anything in here that shouldn't be in v5.x?
08a3f29fd4] - buffer: fix range checking for slowToString (Matt Loring) #4019e3a8e8bba4] - buffer: Prevent Buffer constructor deopt (Bryce Baril) #41580e18e68324] - buffer: fix writeInt{B,L}E for some neg values (Peter A. Bigot) #3994ab5b529dd2] - buffer: default to UTF8 in byteLength() (Tom Gallacher) #4010fcf0e8ebdf] - buffer: move checkFloat from lib into src (Matt Loring) #376312649f4496] - build: add "--partly-static" build options (Super Zheng) #4152a76d788119] - build: update signtool description, add url (Rod Vagg) #4011ed255abdc1] - (SEMVER-MINOR) build,src: add Intel Vtune profiling support (Chunyang Dai) #37857793c364fc] - child_process: flush consuming streams (Dave) #4071f29c5d6e70] - configure:v8_use_snapshotshould betrue(Fedor Indutny) #3962da5ac55c83] - (SEMVER-MINOR) crypto: simplify using pre-existing keys with ECDH (Michael Ruddy) #3511cfc97641ee] - crypto: fix native module compilation with FIPS (Stefan Budeanu) #4023b81b45dabd] - crypto: update root certificates (Ben Noordhuis) #3951def681a07e] - crypto: disable crypto.createCipher in FIPS mode (Stefan Budeanu) #3754ce423f3624] - debugger: introduce exec method for debugger (Jackson Tian)99fd1ec28d] - deps: backport 819b40a from V8 upstream (Michaël Zasso) #3937634c5f1f81] - doc: url.format - true slash postfix behaviour (fansworld-claudio) #41196f957a70d8] - doc: s/node.js/Node.js in readme (Rod Vagg) #39980cd4a52392] - doc: improve child_process.markdown wording (yorkie) #4138fd5ed6888d] - doc: add JungMinu to collaborators (Minwoo Jung) #4143fa0cdf75d9] - doc: add iarna to collaborators (Rebecca Turner) #4144424eb962b1] - doc: add zkat to collaborators (Kat Marchán) #414285b601224b] - doc: add HTTP working group (James M Snell) #3919f4164bd8df] - doc: update links to use https where possible (jpersson) #40543169eed1e3] - doc: add links and backticks around names (jpersson) #4054f3417e2574] - doc: standardize references to node.js in docs (Scott Buchanan) #413695dd60c657] - doc: reword https.Agent example text (Jan Krems) #4075c61237d3ea] - doc: fix internal link to child.send() (Luigi Pinca) #4089aaeced915e] - doc: fix the exception description (yorkie) #3658a2b7596ac0] - doc: fix color of linked code blocks (jpersson) #4068f3c50f5fb5] - doc: fix rare case of misaligned columns (Roman Reiss) #3948f0a2e2cdec] - doc: message.header duplication correction (Bryan English) #3997b1dfa8bebb] - doc: fix typo in README (Rich Trott) #40004602e01221] - doc: replace sane with reasonable (Lewis Cowper) #39804849a54386] - doc: Adding best practises for crypto.pbkdf2 (Tom Gallacher) #329077251d99de] - doc: numeric flags to fs.open (Carl Lei) #3641f4ca007b42] - doc: clarify that fs streams expect blocking fd (Carl Lei) #364126eeae8016] - doc: fix broken references (Alexander Gromnitsky) #3944f90227b0e8] - doc: move fs.existsSync() deprecation message (Martin Forsberg) #3942bbcb2a2e65] - doc: clarify module loading behavior (cjihrig) #39200997178037] - doc: add reference for buffer.inspect() (cjihrig) #39216c16c40283] - doc: clarify v5.1.1 notable items (Rod Vagg) #41564c8800c2de] - fs,doc: usetargetinstead ofdestination(yorkie) #39121f0e8dca8e] - installer: install the tick processor (Matt Loring) #3032e8e4e0718b] - meta: remove use of profanity in source (Myles Borins) #412213834caa28] - module: fix column offsets in errors (Tristian Flanagan) #28678988e1e117] - module,repl: remove repl require() hack (Ben Noordhuis) #4026baac81d95f] - net: add local address/port for better errors (Jan Schär) #394612754c5dc3] - net: small code cleanup (Jan Schär) #39438a5e4345fd] - node: s/doNTCallbackX/nextTickCallbackWithXArgs/ (Rod Vagg) #41670869ef3c55] - (SEMVER-MINOR) repl: allow leading period in multiline input (Zirak) #3835aaab108dfe] - repl: attach location info to syntax errors (cjihrig) #4013da3137d0c5] - src: don't print garbage errors (cjihrig) #41129e9346fa32] - src: use GetCurrentProcessId() for process.pid (Ben Noordhuis) #4163d969c0965c] - src: define Is* util functions with macros (cjihrig) #4118458facdf66] - src: define getpid() based on OS (cjihrig) #41467e18f2ec62] - (SEMVER-MINOR) src: add BE support to StringBytes::Encode() (Bryon Leung) #3410756ab9caad] - stream: be less eager with readable flag (Brian White) #41418f845ba28a] - stream_wrap: error if stream has StringDecoder (Fedor Indutny) #40311c1af81ea0] - streams: update .readable/.writable to false (Brian White) #40831d50819c85] - test: check range fix for slowToString (Sakthipriyan Vairamani) #40190c2a0dc859] - test: skip long path tests on non-Windows (Rafał Pocztarski) #41168a60aa1303] - test: don't check the # of chunks in test-http-1.0 (Santiago Gimeno) #3961e84aeec883] - test: mark test-cluster-shared-leak flaky (Rich Trott) #4162b3f3b2e157] - test: fix cluster-worker-isdead (Santiago Gimeno) #3954da6be4d31a] - test: fix time resolution constraint (Gireesh Punathil) #39819d16729b20] - test: skip instead of fail when mem constrained (Michael Cornacchia) #3697be41eb751b] - test: refactor test-http-exit-delay (Rich Trott) #40554b43bf0385] - test: fix flaky test-net-socket-local-address (Rich Trott) #4109cb55c67a00] - test: improve cluster-disconnect-handles test (Brian White) #40842b5b127e14] - test: fix cluster-disconnect-handles flakiness (Santiago Gimeno) #4009430264817b] - test: add test for repl.defineCommand() (Bryan English) #390822b0971222] - test: eliminate multicast test FreeBSD flakiness (Rich Trott) #4042c50003746b] - test: mark test flaky on FreeBSD (Rich Trott) #401669c95bbdb7] - test: move ArrayStream to common (cjihrig) #4027d94a70ec51] - test: fix test-domain-exit-dispose-again (Julien Gilli) #399000b839a2b8] - test: use platform-based timeout for reliability (Rich Trott) #4015054a216b6f] - test: mark cluster-net-send test flaky on windows (Rich Trott) #4006d0621c5649] - test: mark fork regression test flaky on windows (Rich Trott) #400519ed33df80] - test: skip test if in FreeBSD jail (Rich Trott) #3995a863e8d667] - test: remove flaky status for cluster test (Rich Trott) #3975dd0d15fc47] - test: add TAP diagnostic message for retried tests (Rich Trott) #39601fe4d30efc] - test: retry on smartos if ECONNREFUSED (Rich Trott) #3941665a35d45e] - test: address flaky test-http-client-timeout-event (Rich Trott) #3968f9fe0aee53] - test: numeric flags to fs.open (Carl Lei) #364154aafa17af] - test: http complete list of non-concat headers (Bryan English) #3930788541b40c] - test: fix race condition in unrefd interval test (Michael Cornacchia) #3550e129d83996] - test: skip/replace weak crypto tests in FIPS mode (Stefan Budeanu) #3757bc27379453] - test: avoid test timeouts on rpi (Stefan Budeanu) #3902272732e76b] - test: fix flaky test-child-process-spawnsync-input (Rich Trott) #3889781f8c0d1e] - test: add OS X to module loading error test (Evan Lucas) #3901f99c6363de] - test: module loading error fix solaris node5: test-module-loading-error.js fails #3798 (fansworld-claudio) #38551279adc756] - timers: optimize callback call: bind -> arrow (Andrei Sedoi) #40381c1c1a0f2b] - (SEMVER-MINOR) tools: add --prof-process flag to node binary (Matt Loring) #4021d7a7d3e6f7] - tools: update certdata.txt (Ben Noordhuis) #39511b434e0654] - util: determine object types in C++ (cjihrig) #4100c93e2678f0] - util: fix constructor/instanceof checks (Brian White) #3385098a3113e1] - util: move .decorateErrorStack to internal/util (Ben Noordhuis) #4026e68ea16c32] - util: add decorateErrorStack() (cjihrig) #4013c584c3e08f] - util,src: allow lookup of hidden values (cjihrig) #3988Commits that are on
mastersince v5.1.0 that are not labelled withsemver-majorbut are not included inv5.xare:e2dec98837] - deps: upgrade to V8 4.7.80.25 (Ali Ijaz Sheikh) #4160e935a5214c] - 2015-12-04, Version 4.2.3 "Argon" (LTS) Release (Rod Vagg) nodejs/node-private#1207d8741ddf] - 2015-12-04, Version 0.12.9 (Stable) (Rod Vagg) nodejs/node-private#132c61b84772] - 2015-12-04, Version 0.10.41 (Maintenance) (Rod Vagg) nodejs/node-private#15483016ffd9] - 2015-11-25 Version 0.12.8 (LTS) Release (Rod Vagg) #28061e324d883e] - deps: backport bc2e393 from v8 upstream (evan.lucas) #4106d9d050d396] - deps: cherry-pick 68e89fb from v8's upstream (Fedor Indutny) #4106edfc8cde04] - deps: backport 1ee712a from V8 upstream (Julien Gilli) #4106dc09bbe3ee] - test: fix test-repl-tab-complete after V8 upgrade (Ali Ijaz Sheikh) #41068a43a3d761] - deps: upgrade V8 to 4.7.80.24 (Ali Ijaz Sheikh) #4106I think we need a label for these to say they shouldn't be cherry-picked to v5.x.