src: define Is* util functions with macros #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
the
c++
| X(IsTypedArray) | ||
| X(IsArrayBuffer) | ||
| X(IsDataView) | ||
| #undef X |
There was a problem hiding this comment.
You can improve on this with a map macro:
#define VALUE_METHOD_MAP(V) \
V(isArrayBuffer, IsArrayBuffer) \
V(isDataView, IsDataView) \
// etc.Then:
#define V(_, ucname) \
static void ucname(const FunctionCallbackInfo<Value>& args) { \
// etc.
VALUE_METHOD_MAP(V)
#undef VAnd further down below:
#define V(lcname, ucname) env->SetMethod(target, #lcname, ucname);
VALUE_METHOD_MAP(V)
#undef V
|
@bnoordhuis updated |
|
LGTM |
|
Marking this as an LTS watch but I'm not convinced yet we should land it there. |
|
LGTM |
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Dec 4, 2015
The Is* type checking functions in node_util.cc are mostly the same boilerplate. This commit defines them using a macro. Refs: nodejs#4100 PR-URL: nodejs#4118 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 8, 2015
Closed
|
this relies on #4100 to land |
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Jan 7, 2016
The Is* type checking functions in node_util.cc are mostly the same boilerplate. This commit defines them using a macro. Refs: nodejs#4100 PR-URL: nodejs#4118 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Conflicts: src/node_util.cc
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
The Is* type checking functions in node_util.cc are mostly the same boilerplate. This commit defines them using a macro. Refs: nodejs#4100 PR-URL: nodejs#4118 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Is*type checking functions innode_util.ccare mostly the same boilerplate. This commit defines them using a macro.Refs: #4100
R=@bnoordhuis