Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test flaky on FreeBSD #4016

Closed
wants to merge 1 commit into from
Closed

test: mark test flaky on FreeBSD #4016

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 25, 2015

Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: #2475

@Trott
test: mark test flaky on FreeBSD
ef07dcc 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: nodejs#2475
@Trott Trott added test Issues and PRs related to the tests. freebsd Issues and PRs related to the FreeBSD platform. labels Nov 25, 2015
@jbergstroem
Copy link
Member

😢 LGTM

@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Nov 25, 2015
@bnoordhuis
Copy link
Member

LGTM, sadly.

Trott added a commit to Trott/io.js that referenced this pull request Nov 27, 2015
@Trott
test: mark test flaky on FreeBSD
e25f868 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: nodejs#2475
PR-URL: nodejs#4016
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Trott
Copy link
Member Author

Trott commented Nov 27, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/865/

Landed in e25f868

@Trott Trott closed this Nov 27, 2015
Trott added a commit that referenced this pull request Dec 1, 2015
@Trott
test: mark test flaky on FreeBSD
d7637c9 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: #2475
PR-URL: #4016
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Trott added a commit that referenced this pull request Dec 4, 2015
@Trott @rvagg
test: mark test flaky on FreeBSD
7c528b7 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: #2475
PR-URL: #4016
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Trott added a commit that referenced this pull request Dec 5, 2015
@Trott @rvagg
test: mark test flaky on FreeBSD
c500037 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: #2475
PR-URL: #4016
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Dec 8, 2015
Closed
Merged
@jasnell jasnell mentioned this pull request Dec 17, 2015
Closed
Trott added a commit that referenced this pull request Dec 17, 2015
@Trott @jasnell
test: mark test flaky on FreeBSD
4ea1a69 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: #2475
PR-URL: #4016
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Trott added a commit that referenced this pull request Dec 23, 2015
@Trott @jasnell
test: mark test flaky on FreeBSD
f738fe4 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: #2475
PR-URL: #4016
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: mark test flaky on FreeBSD
ba05f2a 
Mark test-net-socket-local-address flaky on FreeBSD. It times out with
some frequency on CI.

Ref: nodejs#2475
PR-URL: nodejs#4016
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
freebsd Issues and PRs related to the FreeBSD platform. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jbergstroem @bnoordhuis @mscdex @jasnell @MylesBorins