deps: update ICU to 69.1

[targos]

Refs: https://github.com/unicode-org/icu/releases/tag/release-69-1

Full release notes: http://site.icu-project.org/download/69

Common Changes

• CLDR 39
  • For Norwegian, "no" is back to being the canonical code, with "nb" treated as equivalent. This aligns handling of Norwegian with other macro language codes.
  • No new locales, but many improvements and bug fixes; see the CLDR release page
• Number and measurement unit formatting:
  • Measurement unit case and gender (technology preview) (ICU-21123)
    • unitDisplayCase() setter on NumberFormatter to set grammatical case
    • FormattedNumber::getGender() to return the grammatical gender of the output unit
    • These APIs currently deal in strings: this will change in a future release
  • Binary prefixes in measurement units (KiB, MiB, etc.) (ICU-21357)
  • Formatting of custom compound units (ICU-20941)
  • New option to remove fraction digits on whole numbers ($1.99, $2, $2.01) (ICU-20886)
  • New sign display option "negative" (not on negative zero) (ICU-21484)
  • New resolution for fraction-significant rounding (ICU-20019)
  • NumberRangeFormatter supports span fields (ICU-20421)
• Time zone offsets from local time: New APIs BasicTimeZone::getOffsetFromLocal() (C++ & Java) and ucal_getTimeZoneOffsetFromLocal() (ICU-21372 & ICU-21490)
• Time zone data (tzdata) version 2021a (2021-jan)

ICU4C Specific Changes

• New NumberFormatter rounding modes: half-odd, half-ceiling, half-floor (ICU-21493)
• By default, the Layout Extensions library is no longer built even if HarfBuzz is available. (ICU-13837)

[cjihrig]

RSLGTM

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37372/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37395/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37397/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37419/

[jasnell]

@targos ... is it possible to summarize the changes or link to the release notes in the PR post? Makes it easy to reference later after the commit lands. Thank you :-)

[targos]

@jasnell updated the op. is it what you asked?

[jasnell]

Thank you! That's perfect

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37439/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37447/

[gengjiawen]

Landed in ee669a0

[AdamMajer]

I didn't see this until today and now this ICU update breaks builds with older system ICU. For example, while NodeJS 14.17.0 builds just fine, 14.17.1 fails due to requiring newer ICU. In SLES 15 SP2 we have ICU 65.1 which is not new enough,

[  542s] ../deps/v8/src/objects/js-list-format.cc:33:1: error: 'UListFormatterWidth' does not name a type; did you mean 'UListFormatterField'?
[  542s]  UListFormatterWidth GetIcuWidth(JSListFormat::Style style) {
[  542s]  ^~~~~~~~~~~~~~~~~~~
[  542s]  UListFormatterField
[  542s] ../deps/v8/src/objects/js-list-format.cc:45:1: error: 'UListFormatterType' does not name a type; did you mean 'UListFormatter'?
[  542s]  UListFormatterType GetIcuType(JSListFormat::Type type) {
[  542s]  ^~~~~~~~~~~~~~~~~~
[  542s]  UListFormatter
...

What is the policy on breaking compatibility with external dependencies during the LTS lifecycle?

[richardlau]

@AdamMajer Thanks for bringing that to our attention. We discussed this in today's Release WG meeting and for this immediate problem I'm going to see if we can patch/revert 40df0dc as that's the V8 backport that has broken compilation against ICU 65. If not, we'll revert the whole of #38497 (the backport and the ICU 69 update) in 14.x.

Out of interest, does SLES patch Node.js to avoid the error from configure if the system ICU is 65? On Fedora 32 I get:

bash-5.0$ git describe HEAD
v14.17.0
bash-5.0$ ./configure --with-intl=system-icu --verbose
Node.js configure: Found Python 3.8.10...
Detected C++ compiler (CXX=ccache g++) version: 10.3.1
Detected C compiler (CC=ccache gcc) version: 10.3.1
creating icu_config.gypi
ERROR: icu4c v65.1 is too old, v67.x or later is required.
bash-5.0$

due to https://github.com/nodejs/node/blob/v14.17.0/tools/icu/icu_versions.json (it was bumped up in #34356 and I'll see if we can reset it back to 65).

We've also opened nodejs/Release#679 to continue the generalized discussion around ICU updates.

[AdamMajer]

@richardlau you are correct, this is indeed patched to allow compilation with 65. If it indeed continues to function with with icu 67, I guess it's OK and something we will have to deal with.