Node.js 16 failures #852

targos · 2021-03-07T14:40:59Z

I started a run (with citgm's main branch) against Node.js master to check the current status: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2643/

targos · 2021-03-20T06:43:38Z

New run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2650/

@devinivy It looks like hapi is going to have issues: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2650/nodes=fedora-last-latest-x64/testReport/junit/(root)/citgm/_hapi_hapi_v20_1_1/

@richardlau node-report seems a bit too strict in its tests for version numbers: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2650/nodes=fedora-last-latest-x64/testReport/junit/(root)/citgm/node_report_v2_2_11/

@nodejs/npm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2650/nodes=fedora-last-latest-x64/testReport/junit/(root)/citgm/npm_v7_6_3/

@alexlamsl uglify-js is failing because of a spec change: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2650/nodes=fedora-last-latest-x64/testReport/junit/(root)/citgm/uglify_js_v3_13_1/
See tc39/ecma262#2256

devinivy · 2021-03-20T22:46:03Z

We published hapi 20.1.2, and it should contain fixes for those issues 👍

richardlau · 2021-03-21T00:16:43Z

New run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2650/

@richardlau node-report seems a bit too strict in its tests for version numbers: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2650/nodes=fedora-last-latest-x64/testReport/junit/(root)/citgm/node_report_v2_2_11/

node-report is comparing the versions of Node.js dependencies in the report to process.versions -- the failure is occurring since we use each value in process.versions to construct a regular expression and the version string for OpenSSL for the fork we're now using contains a + character which needs to be escaped for use in a regular expression. Raised nodejs/node-report#147 to fix.

MylesBorins · 2021-03-22T21:38:29Z

@targos the npm failure seems to be related to the pre-release version of Node.js causing weird issues with the npm install phase.

BethGriggs · 2021-04-07T01:10:11Z

richardlau · 2021-04-07T01:23:17Z

* [ ]  undici-v3.3.3
  
  * [Link](https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2671/nodes=debian9-64/testReport/(root)/citgm/undici_v3_3_3/)

At least one of the failures,

     # Subtest: 20 times GET with pipelining 10
         1..61
         not ok 1 - (unnamed test)
           ---
           code: DEP0111
           ...

Is the process.binding deprecation which was removed from undici in nodejs/undici#564 but hasn't been released.
Refs: nodejs/node#37813 (comment).

BethGriggs · 2021-04-08T01:23:33Z

I can reproduce the npm-v7.8.0 failures locally on the v16.0.0-proposal build 🤔

➜  cli git:(latest) ✗ ~/node/out/Release/node --version
v16.0.0
➜  cli git:(latest) ✗ ~/node/out/Release/node ~/cli/node_modules/tap/bin/run.js
Error: Cannot find module './reports/base'
Require stack:
- /Users/bgriggs/cli/node_modules/jackspeak/noop.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:940:15)
    at resolveFileName (/Users/bgriggs/cli/node_modules/tap/node_modules/resolve-from/index.js:17:39)
    at resolveFrom (/Users/bgriggs/cli/node_modules/tap/node_modules/resolve-from/index.js:31:9)
    at module.exports (/Users/bgriggs/cli/node_modules/tap/node_modules/resolve-from/index.js:34:41)
    at importJSX (/Users/bgriggs/cli/node_modules/tap/node_modules/import-jsx/index.js:24:21)
    at module.exports (/Users/bgriggs/cli/node_modules/tap/node_modules/treport/lib/index.js:13:18)
    at exports.makeReporter (/Users/bgriggs/cli/node_modules/tap/bin/run.js:422:23)
    at runTests (/Users/bgriggs/cli/node_modules/tap/bin/run.js:744:3)
    at mainAsync (/Users/bgriggs/cli/node_modules/tap/bin/run.js:244:5)
    at main (/Users/bgriggs/cli/node_modules/tap/bin/run.js:127:3) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/Users/bgriggs/cli/node_modules/jackspeak/noop.js' ]
}

My git bisect is pointing to the V8 9.0 upgrade nodejs/node#37587 - as the last known good commit to build/pass npm test appears to be the previous commit, 802b3e7cf9. But I haven't yet convinced myself that #37587 is responsible (or why).

/cc @nodejs/npm

ruyadorno · 2021-04-08T19:12:39Z

hi @BethGriggs! That is looking more like a https://github.com/tapjs/node-tap (which is the test framework we're using) problem than a npm one, we'll dig into it!

BethGriggs · 2021-04-09T00:21:16Z

Thanks @ruyadorno. From further digging around tap I found tapjs/tapjs#624 - which shows a similar/relevant error. As suggested there, passing --reporter classic does run through the test suite and the npm suite passes. So I suspect this issue would impact more than just npm's test suite.

BethGriggs · 2021-04-20T09:44:39Z

targos · 2021-04-20T09:51:11Z

citgm.jest-v26.6.3
Received message: [31m"exports.createRequireFromPath is not a function"

@SimenB

SimenB · 2021-04-20T10:04:01Z

Thanks for the heads up! From nodejs/node#37201 I assume - will tweak our tests (we have some feature detection so it's a fallback if createRequire isn't there, seems we've messed that up).

EDIT: Actually, this is the feature detection working correctly, but the test didn't handle it missing in our implementation when it was missing in Node's implementation 😅

Fix: jestjs/jest@a5ac3c5

Since the error is just in tests and we're currently in a pre-release, would it be possible to have CITGM install from master instead of published release? Finagling branches and releases in the monorepo is more painful than it needs to be, and since the change is only in a test I'd like to avoid it 🙈

v16 added to CI, fwiw

BethGriggs · 2021-04-20T10:23:19Z

citgm.fastify-v3.14.2
Various - including 'not ok 7 - test/close-pipelining.test.js'

@mcollina just FYI in case this isn't on your radar yet, fastify is failing on master/v16.0.0-rc.5 - link to CITGM error

ljharb · 2021-04-20T13:14:44Z

Can you link to the failure for resolve, so i can look into it?

targos · 2021-04-20T13:31:09Z

@ljharb https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2671/nodes=win-vs2019/testReport/junit/(root)/citgm/resolve_v1_20_0/

mcollina · 2021-04-20T21:59:06Z

nodejs/undici#754 fixes the problem for Fastify.

ljharb · 2021-04-22T05:18:51Z

@targos thanks! has anything changed with symlinks in node 16 that i could investigate? I don't have a windows machine to test on.

BethGriggs · 2021-04-22T12:40:46Z

@ljharb I skimmed back a few CITGM builds and noticed the resolve failure was also present on runs for v15.13.0 and v14.16.1. I'm not sure how far back the failure goes, but I'm thinking that it's possibly related to our CITGM set up.

Would any one with a Windows box mind confirming if resolve's tests pass locally (both directly and through CITGM)?

targos · 2021-04-22T12:48:50Z

It's possible that the Windows machines in CI are not configured in development mode. This is mandatory to be able to create symlinks from a non-administrator account.

ljharb · 2021-04-22T15:10:59Z

Thanks, hopefully that’s the case :-)

(Some tooling that’d be nice is auto-filing an issue when something fails a few times in a row, and tagging the maintainers of that package)

ljharb · 2021-06-14T15:28:31Z

@targos Are the resolve failures on windows … resolved?

targos · 2021-06-14T16:18:00Z

@ljharb no, resolve still fails on Windows

ljharb · 2021-06-14T17:25:19Z

Is there an open issue to track that, since it seems to be CITGM-specific?

targos · 2021-06-14T17:27:33Z

I don't think so. It should be a nodejs/build issue about enabling symlinks on Windows machines

Also adds 16.x (latest LTS) to testing suite. xref: tapjs/tapjs#624 The issue is closed, but it is still being reported. xref: nodejs/citgm#852 (comment) This is the fix being used in this commit.

targos mentioned this issue Mar 15, 2021

Node.js 15 failures #836

Closed

6 tasks

targos mentioned this issue Mar 20, 2021

2021-04-20, Version 16.0.0 (Current) nodejs/node#37678

Merged

This was referenced Mar 20, 2021

Future-proof hapi for node v16, rely on res close rather than req hapijs/hapi#4225

Merged

Fix abort test timing to be consistent from node v12 through v16 hapijs/hapi#4239

Merged

alexlamsl mentioned this issue Mar 20, 2021

document various v8 bugs mishoo/UglifyJS#4808

Merged

richardlau mentioned this issue Mar 21, 2021

Escape version strings passed to regular expression matchers nodejs/node-report#147

Open

alexlamsl mentioned this issue Apr 7, 2021

Latest v8 breakages from Node.js v16 mishoo/UglifyJS#4846

Closed

devinivy mentioned this issue Apr 10, 2021

btoa() and atob() nodejs/node#3462

Closed

devinivy mentioned this issue Apr 17, 2021

Add node v16 globals hapijs/lab#1003

Closed

BethGriggs mentioned this issue Apr 20, 2021

Error: Cannot find module './reports/base' tapjs/tapjs#624

Closed

ruyadorno mentioned this issue Apr 20, 2021

tap runner is not working in node16 tapjs/tapjs#746

Closed

mcollina mentioned this issue Apr 20, 2021

Fix Node v16 support and update tap nodejs/undici#754

Merged

devinivy mentioned this issue Apr 23, 2021

Update test suite to cover node v16 hapijs/hapi#4248

Merged

SimenB mentioned this issue May 5, 2021

chore: test using node 16, remove node 10 #862

Merged

4 tasks

targos closed this as completed Jun 14, 2021

Fil mentioned this issue Sep 9, 2021

Fil/xlsx observablehq/stdlib#249

Merged

gfyoung mentioned this issue Nov 3, 2021

Tap + Internal Caching Fixes kaelzhang/node-ignore#74

Merged

zachazar mentioned this issue Dec 9, 2022

Add test reporter to test package.json script ovhemert/pino-datadog#94

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node.js 16 failures #852

Node.js 16 failures #852

targos commented Mar 7, 2021

targos commented Mar 20, 2021

devinivy commented Mar 20, 2021

richardlau commented Mar 21, 2021

MylesBorins commented Mar 22, 2021

BethGriggs commented Apr 7, 2021 •

edited

Loading

richardlau commented Apr 7, 2021

BethGriggs commented Apr 8, 2021

ruyadorno commented Apr 8, 2021

BethGriggs commented Apr 9, 2021

BethGriggs commented Apr 20, 2021 •

edited

Loading

targos commented Apr 20, 2021

SimenB commented Apr 20, 2021 •

edited

Loading

BethGriggs commented Apr 20, 2021

ljharb commented Apr 20, 2021

targos commented Apr 20, 2021

mcollina commented Apr 20, 2021

ljharb commented Apr 22, 2021

BethGriggs commented Apr 22, 2021

targos commented Apr 22, 2021

ljharb commented Apr 22, 2021

ljharb commented Jun 14, 2021

targos commented Jun 14, 2021

ljharb commented Jun 14, 2021

targos commented Jun 14, 2021

Node.js 16 failures #852

Node.js 16 failures #852

Comments

targos commented Mar 7, 2021

targos commented Mar 20, 2021

devinivy commented Mar 20, 2021

richardlau commented Mar 21, 2021

MylesBorins commented Mar 22, 2021

BethGriggs commented Apr 7, 2021 • edited Loading

richardlau commented Apr 7, 2021

BethGriggs commented Apr 8, 2021

ruyadorno commented Apr 8, 2021

BethGriggs commented Apr 9, 2021

BethGriggs commented Apr 20, 2021 • edited Loading

targos commented Apr 20, 2021

SimenB commented Apr 20, 2021 • edited Loading

BethGriggs commented Apr 20, 2021

ljharb commented Apr 20, 2021

targos commented Apr 20, 2021

mcollina commented Apr 20, 2021

ljharb commented Apr 22, 2021

BethGriggs commented Apr 22, 2021

targos commented Apr 22, 2021

ljharb commented Apr 22, 2021

ljharb commented Jun 14, 2021

targos commented Jun 14, 2021

ljharb commented Jun 14, 2021

targos commented Jun 14, 2021

BethGriggs commented Apr 7, 2021 •

edited

Loading

BethGriggs commented Apr 20, 2021 •

edited

Loading

SimenB commented Apr 20, 2021 •

edited

Loading