tests: adapt for v8 8.9 #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, CI seems to be on vacation. |
|
Yes, do not know what is up with Travis. AppVeyor runs https://ci.appveyor.com/project/RodVagg/nan |
|
Forced push to trigger CI again but without success for travis. AppVeyor runs but it fails for 0.8 with |
V8 API for ScriptOrigin constructor has changed. Adapt test to compile with v8 8.9. Currently only `ScriptOrigin` instances are consumed by NAN therefore no adaptions in the NAN API are needed to keep build/tests working.
|
I have not tested or looked into it, but if it builds without errors originating from NAN itself, everything should be good.
…On June 10, 2021 12:43:14 AM GMT+03:00, "Hélène Martin" ***@***.***> wrote:
Thanks for pushing this forward, @Flarna and @kkoopa! I've landed here
following a dependency chain that needs updating. Do you know whether
non-test updates will be needed to support V9.0 which ships with Node
16?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#910 (comment)
|
|
Thanks, @kkoopa, that makes sense. I'll aim to try it and report back. |
|
I use latest NAN release since a while without issues. But there are for sure areas of NAN I don't use there. But it would be still nice if this PR could be merged (or a variant of it) to get node/citgm green again and early hints for future issues like moving to v8 9.1 or in node 17. |
|
🚀 🚀 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 API for
ScriptOriginconstructor has changed. Adapt test to compile with v8 8.9.Currently only
ScriptOrigininstances are consumed by NAN therefore no adaptions in the NAN API are needed to keep build/tests working.fixes: #909