Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node v16 globals #1003

Closed
devinivy opened this issue Apr 17, 2021 · 2 comments · Fixed by #1004
Closed

Add node v16 globals #1003

devinivy opened this issue Apr 17, 2021 · 2 comments · Fixed by #1004
Labels
feature New functionality or improvement

Comments

@devinivy
Copy link
Member

Support plan

  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: v16
  • module version: v24
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): standalone, on hapi v16
  • any other relevant information: This follows from reports via citgm: Node.js 16 failures nodejs/citgm#852 (comment)

What problem are you trying to solve?

We would like lab test suites to pass on node v16 without extra configuration. Currently they fail because node v16 has added some new global variables: btoa, atob, and performance.

Do you have a new or modified API suggestion to solve the problem?

We should add btoa, atob, and performance to lab's list of allowed globals in preparation for node v16.

@devinivy devinivy added the feature New functionality or improvement label Apr 17, 2021
@kanongil
Copy link
Contributor

Node 16 has been released, and this is causing my tests to fail on it.

@devinivy
Copy link
Member Author

There is now a PR open for this in #1004 and as a temporary workaround you can configure lab to ignore these globals with -I 'atob,btoa,performance'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants