Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new globals for node v16 #1004

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Add new globals for node v16 #1004

merged 1 commit into from
Apr 21, 2021

Conversation

devinivy
Copy link
Member

Adds atob, btoa, and performance to the list of allowed globals. Resolves #1003.

@devinivy devinivy added the feature New functionality or improvement label Apr 21, 2021
@devinivy devinivy mentioned this pull request Apr 21, 2021
Closed
@Nargonath
Copy link
Member

Thanks Devin for the work. 👍

@devinivy devinivy merged commit 2356e0e into master Apr 21, 2021
@devinivy devinivy deleted the node-16-globals branch April 21, 2021 13:27
@devinivy devinivy added this to the 24.2.0 milestone Apr 21, 2021
@kanongil
Copy link
Contributor

FYI, you can get the actions to test on v16 with something like this: https://github.com/kanongil/hls-playlist-reader/blob/e0b95975f3d6956e5865ecaa19d299e67b4aedea/.github/workflows/node.js.yml#L24-L27

Note the @v2 and check-latest entry, which should fetch and test using the latest release from https://github.com/actions/node-versions/releases.

@devinivy
Copy link
Member Author

This is now released 👍 Thanks for the tip, Gil— that was the missing link!

@devinivy devinivy mentioned this pull request Apr 23, 2021
Merged
@Nargonath
Copy link
Member

Damn thanks @kanongil. I couldn't figure it out either. This definitely was the missing piece.

@Nargonath Nargonath mentioned this pull request Apr 23, 2021
Merged
@crccheck crccheck mentioned this pull request Jan 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nargonath Nargonath Nargonath approved these changes

Assignees

@devinivy devinivy

Labels
feature New functionality or improvement
Projects
None yet
Milestone
24.2.0
Development

Successfully merging this pull request may close these issues.

Add node v16 globals
3 participants
@devinivy @Nargonath @kanongil