Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let header buttons properly adapt to the viewer handler theme #1202

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

juliusknorr
Copy link
Member

Fixes the header button color after switching to material icons in #1153 where the css rules didn't fit anymore for the viewer theme that the text app selects.

Before:
Screenshot 2022-04-04 at 18 48 33

After:
Screenshot 2022-04-04 at 18 48 09

@juliusknorr juliusknorr added the 3. to review Waiting for reviews label Apr 4, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Apr 6, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the bugfix/noid/button-color branch from ea2fc7a to 00d1bba Compare April 6, 2022 08:34
@skjnldsv
Copy link
Member

skjnldsv commented Apr 6, 2022

/compile amend /

Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for looking into this.

@max-nextcloud
Copy link
Contributor

I triggered a rerun of the canceled jobs. No idea why they were canceled. This should still be up to date with the main branch.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/button-color branch from 00d1bba to ba405fe Compare April 7, 2022 07:46
@juliusknorr
Copy link
Member Author

Pushed the build again using the latest node/npm patch releases

@max-nextcloud max-nextcloud merged commit f913d5f into master Apr 7, 2022
@max-nextcloud max-nextcloud deleted the bugfix/noid/button-color branch April 7, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants