Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download button color when previewing text in talk channel #1153

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

CarlSchwan
Copy link
Member

Use material icon instead of CSS class

Before:

image

After:

image

src/views/Viewer.vue Outdated Show resolved Hide resolved
@CarlSchwan CarlSchwan force-pushed the fix/download-sidebar-button-color branch from 397fe29 to a024f86 Compare February 3, 2022 16:41
@juliusknorr
Copy link
Member

Needs another rebase/compile it seems.

@CarlSchwan
Copy link
Member Author

/compile amend /

Use material icon instead of css class

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/download-sidebar-button-color branch from a024f86 to 5c68944 Compare February 3, 2022 19:44
@CarlSchwan
Copy link
Member Author

Looks like cypress failure is unrelated :(

@skjnldsv
Copy link
Member

skjnldsv commented Feb 4, 2022

This version of Nextcloud requires at least PHP 7.4
You are currently running 7.3.23-1+0~20201008.68+debian10~1.gbp30f6c3. Please update your PHP version.

Ahaha, we need to fix nextcloud ci 🙈

@CarlSchwan CarlSchwan merged commit 9ba02ad into master Feb 17, 2022
@CarlSchwan CarlSchwan deleted the fix/download-sidebar-button-color branch February 17, 2022 16:00
@skjnldsv
Copy link
Member

Actually this also needed tests fixes 🙈
#1154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants