Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar has black background and black icons #2374

Closed
AuspeXeu opened this issue May 9, 2022 · 18 comments · Fixed by nextcloud/viewer#1279
Closed

Toolbar has black background and black icons #2374

AuspeXeu opened this issue May 9, 2022 · 18 comments · Fixed by nextcloud/viewer#1279
Labels
bug Something isn't working needs info

Comments

@AuspeXeu
Copy link

AuspeXeu commented May 9, 2022

image

Nextcloud: 24.0.0
Text: 3.5.1

@AuspeXeu AuspeXeu added the bug Something isn't working label May 9, 2022
@juliusknorr
Copy link
Member

I cannot reproduce that on 24.0.0. Could you tell if you have any special accessibility settings enabled in your accounts personal settings?

@AuspeXeu
Copy link
Author

AuspeXeu commented May 9, 2022

What is a bit strange as well, is that the settings page tells me I am on 24.0.0 (docker) but I don't have the extended sharing settings announced in the blog post for 24.0.0. Any clue why that is? Maybe this is correlated?

@juliusknorr
Copy link
Member

Which docker image is it that you are using there? It looks a bit like a regression that might be re related to the current development branch for the next 24 release, so it could be happening if you run a daily snapshot of that.

@AuspeXeu
Copy link
Author

AuspeXeu commented May 9, 2022

I am using the nextcloud:24 tag

@szaimen
Copy link
Contributor

szaimen commented May 9, 2022

can you try clearing your browser cache? I think this should be fixed with NC24...

@juliusknorr
Copy link
Member

Looks like this is not applying the styles from https://github.com/nextcloud/viewer/blob/master/src/views/Viewer.vue#L840-L852 anymore which is a regression on master but I would not expect that on 24

@AuspeXeu
Copy link
Author

AuspeXeu commented May 9, 2022

@szaimen persists even after I clear the cache unfortunately

@juliusknorr
Copy link
Member

juliusknorr commented May 13, 2022

I also cannot reproduce using the latest docker: docker run -d -p 8091:80 nextcloud:24

nextcloud 24 70077b5f562d   14 hours ago    829MB

Can you tell which exact hash your docker image has?

@AuspeXeu
Copy link
Author

Not sure how to tell you this hash. Does this help?

image

@juliusknorr
Copy link
Member

OK, same hash here so no clue on what could cause that other than an outdated browser cache :/

@AuspeXeu
Copy link
Author

Is there a chance that another app interfers?

@juliusknorr
Copy link
Member

Yeah could be worth to try disabling them one by one to see if there is any difference. The actual close button is coming from the viewer app so one additional thing to check would be if that also happens on images.

@AuspeXeu
Copy link
Author

This is what I see during an image preview

image

@avbor
Copy link

avbor commented May 23, 2022

Same here:
image

I use docker (nextcloud:latest) and the first time the problem appeared just after the upgrade to 24.

@walterzilla
Copy link

walterzilla commented Jun 16, 2022

According to my tests the bug depends on accessibility app being disabled, at least.

Debian 11
Apache 2.4
PHP 8.0
NC 24.0.1 new installation with default app

@avbor
Copy link

avbor commented Jun 16, 2022

Yea, when i enable Accessibility App, toolbar looks like:
image
But, it helps because it changes the background of the toolbar to light.
The question of why the buttons remain dark on a dark background is open.

@walterzilla
Copy link

Yep, with bug I was in the first place referring to the toolbar background color turning dark, btw enabling the dark theme (never tried before), buttons turn properly white.

@danxuliu
Copy link
Member

This is a regression introduced in nextcloud/viewer#1202 @juliushaertl

The colour of the buttons in the modal header is set to white, but now the colour of the SVG element inside the button is always overriden with the color of the text, thus causing the button to become (almost) black.

Note that the accessibility app needs to be disabled, otherwise the bug can not be reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs info
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants