-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar has black background and black icons #2374
Comments
I cannot reproduce that on 24.0.0. Could you tell if you have any special accessibility settings enabled in your accounts personal settings? |
What is a bit strange as well, is that the settings page tells me I am on 24.0.0 (docker) but I don't have the extended sharing settings announced in the blog post for 24.0.0. Any clue why that is? Maybe this is correlated? |
Which docker image is it that you are using there? It looks a bit like a regression that might be re related to the current development branch for the next 24 release, so it could be happening if you run a daily snapshot of that. |
I am using the |
can you try clearing your browser cache? I think this should be fixed with NC24... |
Looks like this is not applying the styles from https://github.com/nextcloud/viewer/blob/master/src/views/Viewer.vue#L840-L852 anymore which is a regression on master but I would not expect that on 24 |
@szaimen persists even after I clear the cache unfortunately |
I also cannot reproduce using the latest docker:
Can you tell which exact hash your docker image has? |
OK, same hash here so no clue on what could cause that other than an outdated browser cache :/ |
Is there a chance that another app interfers? |
Yeah could be worth to try disabling them one by one to see if there is any difference. The actual close button is coming from the viewer app so one additional thing to check would be if that also happens on images. |
According to my tests the bug depends on accessibility app being disabled, at least. Debian 11 |
Yep, with bug I was in the first place referring to the toolbar background color turning dark, btw enabling the dark theme (never tried before), buttons turn properly white. |
This is a regression introduced in nextcloud/viewer#1202 @juliushaertl The colour of the buttons in the modal header is set to white, but now the colour of the SVG element inside the button is always overriden with the color of the text, thus causing the button to become (almost) black. Note that the accessibility app needs to be disabled, otherwise the bug can not be reproduced. |
Nextcloud: 24.0.0
Text: 3.5.1
The text was updated successfully, but these errors were encountered: