-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(s3): fix handling verify_bucket_exists parameter #39017
Conversation
/backport to stable27 |
/backport to stable26 |
/backport to stable25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
Documentation covered few weeks back in nextcloud/documentation#10437 & nextcloud/documentation#10436
There are also (some # of) installations out there with Probably too late (risky) to make that parameter equivalent now without blowback. Also, probably not a big deal as long as it: (a) now works (b) the correct parameter is now documented. |
f208387
to
6df781e
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I've marked the above messages off-topic as the bug was present from the very beginning this feature (and the parameter) was introduced. |
6df781e
to
c2fc3b8
Compare
c2fc3b8
to
3726f3f
Compare
If 'verify_bucket_exists' is set to false in the config.php s3 configuration, it's supposed to avoid verifying that the bucket exists. However empty(falsy) will always return true, so this condition would not work. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
3726f3f
to
3f28fc5
Compare
If
'verify_bucket_exists'
is set to false in theconfig.php
s3 configuration, it's supposed to avoid verifying that the bucket exists. Howeverempty(falsy)
will always return true, so this condition would not work.Follow-up to #23932
Checklist