Allow config to specify the bucket exists #23932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 99% case the bucket is just always there. And if it is not the read/write will fail hard anyways. Esp on big instances the Objectstore is not always fast and this can save a few hundered ms of each request that acess the objectstore. In short it is adding 'verify_bucket_exists' => false To the S3 config part Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
I think that should be the default without a configuration option. |
icewind1991
approved these changes
Nov 6, 2020
Get's tricky for multibucket setups, where the needed buckets are created on the fly. |
MorrisJobke
deleted the
enh/s3/do_not_check_bucket_exists_on_every_request
branch
MorrisJobke
added
the
pending documentation
|
Documentation needed. Especially in sample config as well as the implications on multibucket (and preview multibucket setups). |
4 tasks
joshtrichards
added a commit
to joshtrichards/nc-documentation
that referenced
this pull request
Sep 3, 2023
As developed in nextcloud/server#23932 Also includes caveat language re: multibucket scenarios Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 99% case the bucket is just always there. And if it is not the
read/write will fail hard anyways. Esp on big instances the Objectstore
is not always fast and this can save a few hundered ms of each request
that acess the objectstore.
In short it is adding
'verify_bucket_exists' => false
To the S3 config part
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl