(s3 primary) Simplify language, note defaults, better examples #10437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nextcloud#9934 (for primary storage) * Clarifies parameters that may need to be changed when using with Amazon's S3 * Clarifies parameters that must be changed when using non-Amazon hosted S3 * Strips out no-op parameters (default values) from config example * Lists supported parameters by type and their defaults (if any) * Adds example config for non-Amazon hosted S3 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards
added a commit
to joshtrichards/nc-documentation
that referenced
this pull request
May 25, 2023
Fixes nextcloud#9934 (for external storage) * Better document Amazon parameters (i.e. region) * Better document non-Amazon parameters (i.e. hostname) * Unify relevant explanations with S3 Primary Storage changes pending in PR nextcloud#10437 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
juliushaertl
approved these changes
May 28, 2023
|
/backport to stable27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Possible follow-up work: extend a lighter version into docs section for non-primary S3-based External Storage since it's applicable there as well.
🖼️ Screenshots