Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localisation #831

Closed
ostasevych opened this issue Oct 8, 2023 · 3 comments
Closed

Add localisation #831

ostasevych opened this issue Oct 8, 2023 · 3 comments

Comments

@ostasevych
Copy link
Contributor

ostasevych commented Oct 8, 2023 •
edited
Loading

Please, add the localisation of the PDF Viewer app. Here is the zip archive with all necessary files, including
tempales/viewer.php updated with localisation tags
l10n/uk.js
l10n/uk.json strings for the Ukrainian localisation
l10n/en_GB.js
l10n/en_GB.json strings for the Brittish English localisation
localisation.zip

Would that be possible to create the template and add it as a transifex pool, as well?
@danxuliu
Copy link
Member

Thanks for the translations!

Unfortunately, as explained in #826 (review) the translations are already available in PDF.js, and the reason why they are not shown is that the language is got from the browser preferences rather than the Nextcloud settings (which is a bug that should be fixed).

@ostasevych
Copy link
Contributor Author

Thanks for the translations!

Unfortunately, as explained in #826 (review) the translations are already available in PDF.js, and the reason why they are not shown is that the language is got from the browser preferences rather than the Nextcloud settings (which is a bug that should be fixed).

Thank you for your comment. As I've added in that issue, my suggestion is to follow the common rules of placing translation files in the proper folders, thus, creating translation templates, as well as to use Transifex. All other approaches are confusing devs...

@ostasevych
Copy link
Contributor Author

Please, reopen this issue, as it is not solved.

ostasevych added a commit to ostasevych/files_pdfviewer that referenced this issue Mar 29, 2024
@ostasevych
Update viewer.php
53969a4 
Fixing not showing localised strings using Chrome by adding internationalisation tags to `templates/viewer.php` according to the conventional approach in NC to localise apps.

See nextcloud#831

Signed-off-by: Oleksa <ostasevych@users.noreply.github.com>
@ostasevych ostasevych mentioned this issue Mar 29, 2024
Merged
susnux added a commit that referenced this issue Aug 22, 2024
@susnux @ostasevych
fix: not showing localised strings using Chrome
fbdd1a5 
* Resolves #831

Fixing not showing localised strings using Chrome by adding internationalisation
tags to `templates/viewer.php` according to the conventional approach in NC to localise apps.

Co-authored-by: Oleksa <ostasevych@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux mentioned this issue Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: not showing localised strings using Chrome nextcloud/files_pdfviewer
2 participants
@ostasevych @danxuliu