Update viewer.php #938
Merged
Update viewer.php #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing not showing localised strings using Chrome by adding internationalisation tags to `templates/viewer.php` according to the conventional approach in NC to localise apps. See nextcloud#831 Signed-off-by: Oleksa <ostasevych@users.noreply.github.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
susnux
requested changes
Jul 9, 2024
| @@ -33,8 +34,6 @@ | |||
| --> | |||
| <html dir="ltr" mozdisallowselectionprint> | |||
| <head data-workersrc="<?php p($urlGenerator->linkTo('files_pdfviewer', 'js/pdfjs/build/pdf.worker.js')) ?>?v=<?php p($version) ?>" | |||
| data-enableScripting="<?php p($enableScripting ? true : false) ?>" | |||
| data-sandbox="<?php p($urlGenerator->linkTo('files_pdfviewer', 'js/pdfjs/build/pdf.sandbox.js'))?>" | |||
Comment on lines
-167
to
-173
| <div class="editorParamsToolbar hidden doorHangerRight" id="editorStampParamsToolbar"> | ||
| <div class="editorParamsToolbarContainer"> | ||
| <button id="editorStampAddImage" class="secondaryToolbarButton" title="Add image" tabindex="105" data-l10n-id="editor_stamp_add_image"> | ||
| <span data-l10n-id="editor_stamp_add_image_label">Add image</span> | ||
| </button> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
same here, unrelated removal
| </button> | ||
|
|
||
| <div class="verticalToolbarSeparator hiddenMediumView"></div> | ||
|
|
||
| <div id="editorModeButtons" class="splitToolbarButton toggled" role="radiogroup" hidden="true"> | ||
| <button id="editorFreeText" class="toolbarButton" disabled="disabled" title="Text" role="radio" aria-checked="false" aria-controls="editorFreeTextParamsToolbar" tabindex="34" data-l10n-id="editor_free_text2"> |
There was a problem hiding this comment.
why is the aria controls removed? This is needed for accessibility
Comment on lines
-440
to
-483
| <button id="documentPropertiesClose" class="dialogButton"><span data-l10n-id="document_properties_close">Close</span></button> | ||
| </div> | ||
| </dialog> | ||
| <dialog id="altTextDialog" aria-labelledby="dialogLabel" aria-describedby="dialogDescription"> | ||
| <div id="altTextContainer"> | ||
| <div id="overallDescription"> | ||
| <span id="dialogLabel" data-l10n-id="editor_alt_text_dialog_label" class="title">Choose an option</span> | ||
| <span id="dialogDescription" data-l10n-id="editor_alt_text_dialog_description"> | ||
| Alt text (alternative text) helps when people can’t see the image or when it doesn’t load. | ||
| </span> | ||
| </div> | ||
| <div id="addDescription"> | ||
| <div class="radio"> | ||
| <div class="radioButton"> | ||
| <input type="radio" id="descriptionButton" name="altTextOption" tabindex="0" aria-describedby="descriptionAreaLabel" checked> | ||
| <label for="descriptionButton" data-l10n-id="editor_alt_text_add_description_label">Add a description</label> | ||
| </div> | ||
| <div class="radioLabel"> | ||
| <span id="descriptionAreaLabel" data-l10n-id="editor_alt_text_add_description_description"> | ||
| Aim for 1-2 sentences that describe the subject, setting, or actions. | ||
| </span> | ||
| </div> | ||
| </div> | ||
| <div class="descriptionArea"> | ||
| <textarea id="descriptionTextarea" placeholder="For example, “A young man sits down at a table to eat a meal”" aria-labelledby="descriptionAreaLabel" data-l10n-id="editor_alt_text_textarea" tabindex="0"></textarea> | ||
| </div> | ||
| </div> | ||
| <div id="markAsDecorative"> | ||
| <div class="radio"> | ||
| <div class="radioButton"> | ||
| <input type="radio" id="decorativeButton" name="altTextOption" aria-describedby="decorativeLabel"> | ||
| <label for="decorativeButton" data-l10n-id="editor_alt_text_mark_decorative_label">Mark as decorative</label> | ||
| </div> | ||
| <div class="radioLabel"> | ||
| <span id="decorativeLabel" data-l10n-id="editor_alt_text_mark_decorative_description"> | ||
| This is used for ornamental images, like borders or watermarks. | ||
| </span> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div id="buttons"> | ||
| <button id="altTextCancel" tabindex="0"><span data-l10n-id="editor_alt_text_cancel_button">Cancel</span></button> | ||
| <button id="altTextSave" tabindex="0"><span data-l10n-id="editor_alt_text_save_button">Save</span></button> | ||
| </div> |
There was a problem hiding this comment.
why is this removed, seems unrelated.
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing not showing localised strings using Chrome by adding internationalisation tags to
templates/viewer.phpaccording to the conventional approach in NC to localise apps.See #831